Re: [Mesa-dev] [PATCH] radeonsi: don't preload constants at the beginning of shaders

2016-09-10 Thread Nicolai Hähnle
On 10.09.2016 00:40, Marek Olšák wrote: From: Marek Olšák LLVM can CSE the loads, thus we can always re-load constants before each use. The decrease in SGPR spilling is huge. The best improvements are the dumbest ones. Indeed :) Reviewed-by: Nicolai Hähnle 26011 shaders in 14651 tests T

Re: [Mesa-dev] [PATCH] radeonsi: don't preload constants at the beginning of shaders

2016-09-09 Thread Edward O'Callaghan
On 09/10/2016 10:02 AM, Bas Nieuwenhuizen wrote: > Reviewed-by: Bas Nieuwenhuizen Reviewed-by: Edward O'Callaghan > > On Sat, Sep 10, 2016 at 12:40 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> LLVM can CSE the loads, thus we can always re-load constants before each >> use. The decreas

Re: [Mesa-dev] [PATCH] radeonsi: don't preload constants at the beginning of shaders

2016-09-09 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sat, Sep 10, 2016 at 12:40 AM, Marek Olšák wrote: > From: Marek Olšák > > LLVM can CSE the loads, thus we can always re-load constants before each > use. The decrease in SGPR spilling is huge. > > The best improvements are the dumbest ones. > > 26011 shaders in

[Mesa-dev] [PATCH] radeonsi: don't preload constants at the beginning of shaders

2016-09-09 Thread Marek Olšák
From: Marek Olšák LLVM can CSE the loads, thus we can always re-load constants before each use. The decrease in SGPR spilling is huge. The best improvements are the dumbest ones. 26011 shaders in 14651 tests Totals: SGPRS: 1453346 -> 1251920 (-13.86 %) VGPRS: 742576 -> 728421 (-1.91 %) Spilled