Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

2017-05-15 Thread Marek Olšák
On Mon, May 15, 2017 at 4:31 PM, Emil Velikov wrote: > On 15 May 2017 at 13:25, Marek Olšák wrote: >> On Mon, May 15, 2017 at 1:11 PM, Emil Velikov >> wrote: >>> On 13 May 2017 at 20:32, Marek Olšák wrote: Reviewed-by: Marek Olšák Note that this is not meant for master, because

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

2017-05-15 Thread Emil Velikov
On 15 May 2017 at 13:25, Marek Olšák wrote: > On Mon, May 15, 2017 at 1:11 PM, Emil Velikov > wrote: >> On 13 May 2017 at 20:32, Marek Olšák wrote: >>> Reviewed-by: Marek Olšák >>> >>> Note that this is not meant for master, because master doesn't need this fix >>> anymore. >>> >> A tad silly

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

2017-05-15 Thread Marek Olšák
On Mon, May 15, 2017 at 1:11 PM, Emil Velikov wrote: > On 13 May 2017 at 20:32, Marek Olšák wrote: >> Reviewed-by: Marek Olšák >> >> Note that this is not meant for master, because master doesn't need this fix >> anymore. >> > A tad silly question: is that really the case? > AFAICT there's some

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

2017-05-15 Thread Emil Velikov
On 13 May 2017 at 20:32, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Note that this is not meant for master, because master doesn't need this fix > anymore. > A tad silly question: is that really the case? AFAICT there's some related changes with commit 156e81f305b although the patch seem a

Re: [Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

2017-05-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Note that this is not meant for master, because master doesn't need this fix anymore. Marek On Sat, May 13, 2017 at 12:07 AM, Mauro Rossi wrote: > 'if (regs->counters)' expression at line 623 is always true, > spotted because of an error when building android-x86. > >

[Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

2017-05-12 Thread Mauro Rossi
'if (regs->counters)' expression at line 623 is always true, spotted because of an error when building android-x86. 'if (regs->counters[idx])' is used instead. Fixes the following building error in Android: external/mesa/src/gallium/drivers/radeonsi/si_perfcounter.c:617:14: error: address of arr