Re: [Mesa-dev] [PATCH] r600: implement callstack workaround for evergreen.

2018-03-09 Thread Roland Scheidegger
Looks great to me. (I think I even mentioned it looked odd to me that stack workarounds looked different on non-sb when I extended the sb workaround logic to exclude hemlock...) Reviewed-by: Roland Scheidegger Am 09.03.2018 um 07:09 schrieb Dave Airlie: > From: Dave Airlie > > This is ported f

Re: [Mesa-dev] [PATCH] r600: implement callstack workaround for evergreen.

2018-03-09 Thread Elie Tournier
On Fri, Mar 09, 2018 at 04:09:43PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This is ported from the sb backend, there are some issues with > evergreen stacks on the boundary between entries and ALU_PUSH_BEFORE > instructions. > > Whenever we are going to use a push before, we check the

[Mesa-dev] [PATCH] r600: implement callstack workaround for evergreen.

2018-03-08 Thread Dave Airlie
From: Dave Airlie This is ported from the sb backend, there are some issues with evergreen stacks on the boundary between entries and ALU_PUSH_BEFORE instructions. Whenever we are going to use a push before, we check the stack usage and if we have to use the workaround, then we switch to a separ