[Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop

2018-05-31 Thread Gert Wollny
This patch is based on https://lists.freedesktop.org/archives/mesa-dev/2018-February/185805.html Dave Airlie: "A bunch of CTS tests led me to write tests/shaders/ssa/fs-while-loop-rotate-value.shader_test which r600/sb always fell over on. GCM seems to move some of the copies into other b

Re: [Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop

2018-02-19 Thread Gert Wollny
Am Montag, den 19.02.2018, 14:06 +1000 schrieb Dave Airlie: > On 15 February 2018 at 01:26, Gert Wollny > wrote: > > Am Mittwoch, den 14.02.2018, 17:18 +1000 schrieb Dave Airlie: > > > From: Dave Airlie > > > > > > A bunch of CTS tests led me to write > > > tests/shaders/ssa/fs-while-loop-rotate

Re: [Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop

2018-02-18 Thread Dave Airlie
On 15 February 2018 at 01:26, Gert Wollny wrote: > Am Mittwoch, den 14.02.2018, 17:18 +1000 schrieb Dave Airlie: >> From: Dave Airlie >> >> A bunch of CTS tests led me to write >> tests/shaders/ssa/fs-while-loop-rotate-value.shader_test >> which r600/sb always fell over on. >> >> This patch fixes

[Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop (v3)

2018-02-18 Thread Dave Airlie
From: Dave Airlie A bunch of CTS tests led me to write tests/shaders/ssa/fs-while-loop-rotate-value.shader_test which r600/sb always fell over on. This patch fixes it, but I'll probably never be 100% sure why. Anyways what appears to be happening is when gcm is scheduling the copy_movs used for

Re: [Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop (attempt 2)

2018-02-16 Thread Gert Wollny
Am Freitag, den 16.02.2018, 14:44 +1000 schrieb Dave Airlie: > From: Dave Airlie > > A bunch of CTS tests led me to write > tests/shaders/ssa/fs-while-loop-rotate-value.shader_test > which r600/sb always fell over on. > > GCM seems to move some of the copys into other basic blocks, > if we don't

[Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop (attempt 2)

2018-02-15 Thread Dave Airlie
From: Dave Airlie A bunch of CTS tests led me to write tests/shaders/ssa/fs-while-loop-rotate-value.shader_test which r600/sb always fell over on. GCM seems to move some of the copys into other basic blocks, if we don't allow this to happen then it doesn't seem to schedule them badly. Everythin

Re: [Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop

2018-02-14 Thread Gert Wollny
Am Mittwoch, den 14.02.2018, 17:18 +1000 schrieb Dave Airlie: > From: Dave Airlie > > A bunch of CTS tests led me to write > tests/shaders/ssa/fs-while-loop-rotate-value.shader_test > which r600/sb always fell over on. > > This patch fixes it, but I'll probably never be 100% sure why. Unfortuna

[Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop

2018-02-13 Thread Dave Airlie
From: Dave Airlie A bunch of CTS tests led me to write tests/shaders/ssa/fs-while-loop-rotate-value.shader_test which r600/sb always fell over on. This patch fixes it, but I'll probably never be 100% sure why. Anyways what appears to be happening is when gcm is scheduling the copy_movs used for