Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Marek Olšák
I'm going to push this shortly. Thanks. Marek On Mon, Mar 9, 2015 at 4:15 PM, Stefan Dösinger wrote: > This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01 > test as well as the precision part of Wine's 3dc format test (fd.o bug > 89156). > > The Z component seems to contain

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Ilia Mirkin
On Mon, Mar 9, 2015 at 12:26 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2015-03-09 um 17:19 schrieb Ilia Mirkin: >> It also has the additional problem that it doesn't do the swizzle >> workaround which apparently is necessary even for single-component >> te

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2015-03-09 um 17:19 schrieb Ilia Mirkin: > It also has the additional problem that it doesn't do the swizzle > workaround which apparently is necessary even for single-component > textures. Do you mean the change I made in my patch? That part work

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Ilia Mirkin
On Mon, Mar 9, 2015 at 12:11 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2015-03-09 um 16:53 schrieb Stefan Dösinger: >> I did test if LATC_UNORM and LATC_SNORM still work after my fix. >> LATC_SNORM is unchanged (broken in the same way as RGTC_SNORM) and >>

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2015-03-09 um 16:53 schrieb Stefan Dösinger: > I did test if LATC_UNORM and LATC_SNORM still work after my fix. > LATC_SNORM is unchanged (broken in the same way as RGTC_SNORM) and > LATC_UNORM now has the proper precision like RGTC_UNORM. I think

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Thanks for the quick feedback! Am 2015-03-09 um 16:20 schrieb Ilia Mirkin: > I don't suppose you've tried adding RGTC1_SNORM/LATC1_SNORM into > that condition? No, because the codepath isn't entered for them at all. There's an if(format != RGTC1_

Re: [Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Ilia Mirkin
On Mon, Mar 9, 2015 at 11:15 AM, Stefan Dösinger wrote: > This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01 > test as well as the precision part of Wine's 3dc format test (fd.o bug > 89156). This is often identified in the commit message with Bugzilla: https://bugs.freedes

[Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

2015-03-09 Thread Stefan Dösinger
This fixes the GL_COMPRESSED_RED_RGTC1 part of piglit's rgtc-teximage-01 test as well as the precision part of Wine's 3dc format test (fd.o bug 89156). The Z component seems to contain a lower precision version of the result, probably a temporary value from the decompression computation. The Y and