OK, so I actually tested it (and fixed it) now and will post a patch for
review shortly.
-Brian
On 07/01/2013 04:09 PM, Myles C. Maxfield wrote:
Looks good to me. Thanks for fixing it up. Do the prospects look good
for getting this committed?
It would be cool if my name was attached to the p
Looks good to me. Thanks for fixing it up. Do the prospects look good for
getting this committed?
It would be cool if my name was attached to the patch, but since you really
ended up writing it, its fine with me if you're marked as the author.
Thanks,
Myles
On Mon, Jul 1, 2013 at 2:08 PM, Brian
I took a closer look at your patch and I think it's incorrect.
Note that the 'values' pointer is incremented by 4 in each loop
iteration and size is decremented by 4. So accessing values[i*4+j] will
eventually go out of bounds.
I think something like this would work.
diff --git a/src/mesa/p
Friendly ping regarding this patch :-)
--Myles
On Wed, Jun 19, 2013 at 12:47 AM, Myles C. Maxfield <
myles.maxfi...@gmail.com> wrote:
> Any word on this?
>
> Thanks,
> Myles
>
>
> On Mon, Jun 17, 2013 at 12:09 PM, Myles C. Maxfield <
> myles.maxfi...@gmail.com> wrote:
>
>> Sure. I was under the
Any word on this?
Thanks,
Myles
On Mon, Jun 17, 2013 at 12:09 PM, Myles C. Maxfield <
myles.maxfi...@gmail.com> wrote:
> Sure. I was under the impression that |size| couldn't be both greater than
> 4 and a non-multiple of 4, but I've reworked the patch to incorporate this
> and to be a little m
Sure. I was under the impression that |size| couldn't be both greater than
4 and a non-multiple of 4, but I've reworked the patch to incorporate this
and to be a little more straightforward.
Is the only way to replace "ASAN" with "Address Sanitizer" to change the
subject of this email thread?
Any
On 06/14/2013 05:12 PM, Myles C. Maxfield wrote:
Sorry for the triple post; I received a bounce email the first time and got
sent to the spam folder the second time, so I'm trying a third time.
Hello, all. I was running Mesa with Address Sanitizer [1] turned on, and found
one place where ASAN
Sorry for the triple post; I received a bounce email the first time
and got sent to the spam folder the second time, so I'm trying a third
time.
Hello, all. I was running Mesa with Address Sanitizer [1] turned on,
and found one place where ASAN pointed out a read-before-initialized
problem. In par
