Re: [Mesa-dev] [PATCH] panfrost: Kill a useless NULL test in panfrost_job_submit()

Reviewed-by: Alyssa Rosenzweig On Tue, Aug 13, 2019 at 08:35:21PM +0200, Boris Brezillon wrote: > The !job test is done after dereferencing the job pointer, which means > it's either always false or we have a NULL pointer exception. > > Replace that test by an assert() at the beginning of the fu

[Mesa-dev] [PATCH] panfrost: Kill a useless NULL test in panfrost_job_submit()

The !job test is done after dereferencing the job pointer, which means it's either always false or we have a NULL pointer exception. Replace that test by an assert() at the beginning of the function. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_job.c | 4 +--- 1 file chan