Re: [Mesa-dev] [PATCH] nvc0: use nve4_p2mf_push_linear() to reduce code duplication

2016-07-25 Thread Samuel Pitoiset
On 07/26/2016 12:24 AM, Ilia Mirkin wrote: On Mon, Jul 25, 2016 at 6:21 PM, Samuel Pitoiset wrote: On 07/26/2016 12:20 AM, Ilia Mirkin wrote: Sounds reasonable. Pretty sure those NV_VRAM_DOMAIN thingies should just be txc->domain. With that fixed, IIRC, this NV_VRAM_DOMAIN thing is for

Re: [Mesa-dev] [PATCH] nvc0: use nve4_p2mf_push_linear() to reduce code duplication

2016-07-25 Thread Ilia Mirkin
On Mon, Jul 25, 2016 at 6:21 PM, Samuel Pitoiset wrote: > > > On 07/26/2016 12:20 AM, Ilia Mirkin wrote: >> >> Sounds reasonable. Pretty sure those NV_VRAM_DOMAIN thingies should >> just be txc->domain. With that fixed, > > > IIRC, this NV_VRAM_DOMAIN thing is for gk20a, maybe this is going to fix

Re: [Mesa-dev] [PATCH] nvc0: use nve4_p2mf_push_linear() to reduce code duplication

2016-07-25 Thread Samuel Pitoiset
On 07/26/2016 12:20 AM, Ilia Mirkin wrote: Sounds reasonable. Pretty sure those NV_VRAM_DOMAIN thingies should just be txc->domain. With that fixed, IIRC, this NV_VRAM_DOMAIN thing is for gk20a, maybe this is going to fix some tests as a side effect? Reviewed-by: Ilia Mirkin On Mon, Ju

Re: [Mesa-dev] [PATCH] nvc0: use nve4_p2mf_push_linear() to reduce code duplication

2016-07-25 Thread Ilia Mirkin
Sounds reasonable. Pretty sure those NV_VRAM_DOMAIN thingies should just be txc->domain. With that fixed, Reviewed-by: Ilia Mirkin On Mon, Jul 25, 2016 at 6:17 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 45 > ++---

[Mesa-dev] [PATCH] nvc0: use nve4_p2mf_push_linear() to reduce code duplication

2016-07-25 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 45 ++--- 1 file changed, 9 insertions(+), 36 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c b/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c index 8abf1b5..25a5a8e 10064