Re: [Mesa-dev] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

2017-04-29 Thread Karol Herbst
2017-04-29 17:18 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 10:41 AM, Karol Herbst wrote: >> fixes a crash in Alien Isolation > > What crash? assertion, because shladd requires an immediate, there can't be a reg at src1 "shladd u32 $r0 $r0 $r63 $r36" is invalid for the emiter so we have t

Re: [Mesa-dev] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

2017-04-29 Thread Ilia Mirkin
On Sat, Apr 29, 2017 at 10:41 AM, Karol Herbst wrote: > fixes a crash in Alien Isolation What crash? How did the zero get there? Does this only happen if you do your optimization loop thing? In either case, we still want the replaceZero() logic. However that logic should be aware that the middle

[Mesa-dev] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

2017-04-29 Thread Karol Herbst
fixes a crash in Alien Isolation Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/