Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-25 Thread Hans de Goede
Hi, On 24-04-16 23:35, Ilia Mirkin wrote: On Fri, Apr 22, 2016 at 7:06 AM, Hans de Goede wrote: folding indirect add into offset ld src 0x2dda328 ind0 0x27ca558 add def0 0x27ca558 2 ref value 0x27ca558, indirect -1 -1 file 1 size 4 st u32 # g[%r70+0x0] %r38 (0) ref value 0x27ca558, indire

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-24 Thread Ilia Mirkin
On Fri, Apr 22, 2016 at 7:06 AM, Hans de Goede wrote: > Hi, > > > On 21-04-16 17:52, Ilia Mirkin wrote: >> >> On Thu, Apr 21, 2016 at 11:40 AM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> >>> On 21-04-16 17:09, Samuel Pitoiset wrote: On 04/21/2016 04:46 PM, Hans de Goede

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-22 Thread Hans de Goede
Hi, On 21-04-16 17:52, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 11:40 AM, Hans de Goede wrote: Hi, On 21-04-16 17:09, Samuel Pitoiset wrote: On 04/21/2016 04:46 PM, Hans de Goede wrote: Hi, On 21-04-16 16:28, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Ilia Mirkin
On Thu, Apr 21, 2016 at 11:40 AM, Hans de Goede wrote: > Hi, > > > On 21-04-16 17:09, Samuel Pitoiset wrote: >> >> >> >> On 04/21/2016 04:46 PM, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 21-04-16 16:28, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote:

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Hans de Goede
Hi, On 21-04-16 17:09, Samuel Pitoiset wrote: On 04/21/2016 04:46 PM, Hans de Goede wrote: Hi, On 21-04-16 16:28, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote: combineLd/St would combine, i.e. : st u32 # g[$r2+0x0] $r2 st u32 # g[$r2+0x4] $r3 into: st u64

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Ilia Mirkin
On Thu, Apr 21, 2016 at 11:15 AM, Ilia Mirkin wrote: > On Thu, Apr 21, 2016 at 10:46 AM, Hans de Goede wrote: >> Hi, >> >> On 21-04-16 16:28, Ilia Mirkin wrote: >>> >>> On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede >>> wrote: combineLd/St would combine, i.e. : st u32 # g[$r

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Samuel Pitoiset
On 04/21/2016 05:15 PM, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 10:46 AM, Hans de Goede wrote: Hi, On 21-04-16 16:28, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote: combineLd/St would combine, i.e. : st u32 # g[$r2+0x0] $r2 st u32 # g[$r2+0x4] $r3 into:

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Samuel Pitoiset
On 04/21/2016 04:46 PM, Hans de Goede wrote: Hi, On 21-04-16 16:28, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote: combineLd/St would combine, i.e. : st u32 # g[$r2+0x0] $r2 st u32 # g[$r2+0x4] $r3 into: st u64 # g[$r2+0x0] $r2d But this is only valid if r2

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Ilia Mirkin
On Thu, Apr 21, 2016 at 10:46 AM, Hans de Goede wrote: > Hi, > > On 21-04-16 16:28, Ilia Mirkin wrote: >> >> On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede >> wrote: >>> >>> combineLd/St would combine, i.e. : >>> >>> st u32 # g[$r2+0x0] $r2 >>> st u32 # g[$r2+0x4] $r3 >>> >>> into: >>> >>> st

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Hans de Goede
Hi, On 21-04-16 16:28, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote: combineLd/St would combine, i.e. : st u32 # g[$r2+0x0] $r2 st u32 # g[$r2+0x4] $r3 into: st u64 # g[$r2+0x0] $r2d But this is only valid if r2 contains an 8 byte aligned address, which is unk

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Ilia Mirkin
On Thu, Apr 21, 2016 at 9:55 AM, Hans de Goede wrote: > combineLd/St would combine, i.e. : > > st u32 # g[$r2+0x0] $r2 > st u32 # g[$r2+0x4] $r3 > > into: > > st u64 # g[$r2+0x0] $r2d > > But this is only valid if r2 contains an 8 byte aligned address, > which is unknown. > > This commit checks

[Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-21 Thread Hans de Goede
combineLd/St would combine, i.e. : st u32 # g[$r2+0x0] $r2 st u32 # g[$r2+0x4] $r3 into: st u64 # g[$r2+0x0] $r2d But this is only valid if r2 contains an 8 byte aligned address, which is unknown. This commit checks for src0 dim 0 not being indirect when combining loads / stores as combinin