Re: [Mesa-dev] [PATCH] nouveau: Add lots of comments to the buffer transfer logic

2013-12-02 Thread Ilia Mirkin
On Mon, Dec 2, 2013 at 9:31 PM, Chris Forbes wrote: > + * > + * Also marks vbo/cb dirty if the buffer's binding > > Looks like this stops mid-sentence. Hah, yeah. I kinda trailed off there, didn't I. Not sure how to finish that sentence though -- it's if pipe_resource->bind & PIPE_BIND_INDEX/VERT

Re: [Mesa-dev] [PATCH] nouveau: Add lots of comments to the buffer transfer logic

2013-12-02 Thread Chris Forbes
+ * + * Also marks vbo/cb dirty if the buffer's binding Looks like this stops mid-sentence. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nouveau: Add lots of comments to the buffer transfer logic

2013-12-01 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This is my shot at understanding this whole transfer business. The upshot is that after reading through it and understanding it, the transfer logic does appear correct if potentially less-than-perfectly-efficient (e.g. one could keep track of ranges being read/writt