Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-18 Thread Ian Romanick
On 10/16/2018 08:49 PM, Timothy Arceri wrote: > For example: > >vec1 32 ssa_386 = feq ssa_333.x, ssa_6 >vec1 32 ssa_387 = feq ssa_333.x, ssa_2 >vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 >vec1 32 ssa_396 = bcsel ssa_386, ssa_324, ssa_391 > > Can be simplified to: > >ve

Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-17 Thread Timothy Arceri
On 17/10/18 8:49 pm, Bas Nieuwenhuizen wrote: On Wed, Oct 17, 2018 at 5:49 AM Timothy Arceri wrote: For example: vec1 32 ssa_386 = feq ssa_333.x, ssa_6 vec1 32 ssa_387 = feq ssa_333.x, ssa_2 vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 vec1 32 ssa_396 = bcsel ssa_386, ssa

Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-17 Thread Bas Nieuwenhuizen
On Wed, Oct 17, 2018 at 5:49 AM Timothy Arceri wrote: > > For example: > >vec1 32 ssa_386 = feq ssa_333.x, ssa_6 >vec1 32 ssa_387 = feq ssa_333.x, ssa_2 >vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 >vec1 32 ssa_396 = bcsel ssa_386, ssa_324, ssa_391 > > Can be simplified to: >

Re: [Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-17 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2018-10-17 at 14:49 +1100, Timothy Arceri wrote: > For example: > >vec1 32 ssa_386 = feq ssa_333.x, ssa_6 >vec1 32 ssa_387 = feq ssa_333.x, ssa_2 >vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 >vec1 32 ssa_396 = bcsel ssa_386, ssa_324,

[Mesa-dev] [PATCH] nir: remove some redundant bcsel instructions

2018-10-16 Thread Timothy Arceri
For example: vec1 32 ssa_386 = feq ssa_333.x, ssa_6 vec1 32 ssa_387 = feq ssa_333.x, ssa_2 vec1 32 ssa_391 = bcsel ssa_387, ssa_388, ssa_324 vec1 32 ssa_396 = bcsel ssa_386, ssa_324, ssa_391 Can be simplified to: vec1 32 ssa_386 = feq ssa_333.x, ssa_6 vec1 32 ssa_391 = bcsel ss