Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-14 Thread Erik Faye-Lund
On Wed, 2019-02-13 at 11:53 -0800, Ian Romanick wrote: > On 2/13/19 9:59 AM, Juan A. Suarez Romero wrote: > > On Wed, 2019-02-13 at 09:16 -0800, Ian Romanick wrote: > > > On 2/13/19 7:53 AM, Juan A. Suarez Romero wrote: > > > > On Tue, 2019-02-12 at 16:22 -0800, Ian Romanick wrote: > > > > > On 2/1

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-13 Thread Juan A. Suarez Romero
On Wed, 2019-02-13 at 11:53 -0800, Ian Romanick wrote: > On 2/13/19 9:59 AM, Juan A. Suarez Romero wrote: > > On Wed, 2019-02-13 at 09:16 -0800, Ian Romanick wrote: > > > On 2/13/19 7:53 AM, Juan A. Suarez Romero wrote: > > > > On Tue, 2019-02-12 at 16:22 -0800, Ian Romanick wrote: > > > > > On 2/1

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-13 Thread Ian Romanick
On 2/13/19 9:59 AM, Juan A. Suarez Romero wrote: > On Wed, 2019-02-13 at 09:16 -0800, Ian Romanick wrote: >> On 2/13/19 7:53 AM, Juan A. Suarez Romero wrote: >>> On Tue, 2019-02-12 at 16:22 -0800, Ian Romanick wrote: On 2/12/19 12:58 AM, Juan A. Suarez Romero wrote: > opt_split_alu_of_phi

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-13 Thread Juan A. Suarez Romero
On Wed, 2019-02-13 at 09:16 -0800, Ian Romanick wrote: > On 2/13/19 7:53 AM, Juan A. Suarez Romero wrote: > > On Tue, 2019-02-12 at 16:22 -0800, Ian Romanick wrote: > > > On 2/12/19 12:58 AM, Juan A. Suarez Romero wrote: > > > > opt_split_alu_of_phi moves ALU instruction to the end of continue bloc

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-13 Thread Ian Romanick
On 2/13/19 7:53 AM, Juan A. Suarez Romero wrote: > On Tue, 2019-02-12 at 16:22 -0800, Ian Romanick wrote: >> On 2/12/19 12:58 AM, Juan A. Suarez Romero wrote: >>> opt_split_alu_of_phi moves ALU instruction to the end of continue block. >>> >>> But if the continue block ends with a jump instruction

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-13 Thread Juan A. Suarez Romero
On Tue, 2019-02-12 at 16:22 -0800, Ian Romanick wrote: > On 2/12/19 12:58 AM, Juan A. Suarez Romero wrote: > > opt_split_alu_of_phi moves ALU instruction to the end of continue block. > > > > But if the continue block ends with a jump instruction (an explicit > > "continue" instruction) then the A

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-12 Thread Jason Ekstrand
On February 12, 2019 18:22:36 Ian Romanick wrote: On 2/12/19 12:58 AM, Juan A. Suarez Romero wrote: opt_split_alu_of_phi moves ALU instruction to the end of continue block. But if the continue block ends with a jump instruction (an explicit "continue" instruction) then the ALU must be inserte

Re: [Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-12 Thread Ian Romanick
On 2/12/19 12:58 AM, Juan A. Suarez Romero wrote: > opt_split_alu_of_phi moves ALU instruction to the end of continue block. > > But if the continue block ends with a jump instruction (an explicit > "continue" instruction) then the ALU must be inserted before the jump, > as it is illegal to add in

[Mesa-dev] [PATCH] nir: move ALU instruction before the jump instruction

2019-02-12 Thread Juan A. Suarez Romero
opt_split_alu_of_phi moves ALU instruction to the end of continue block. But if the continue block ends with a jump instruction (an explicit "continue" instruction) then the ALU must be inserted before the jump, as it is illegal to add instructions after the jump. CC: Ian Romanick Fixes: 0881e90