Re: [Mesa-dev] [PATCH] nir: add nir_swizzle

2015-09-11 Thread Rob Clark
On Thu, Sep 10, 2015 at 8:03 PM, Erik Faye-Lund wrote: > On Thu, Sep 10, 2015 at 10:08 PM, Rob Clark wrote: >> From: Rob Clark >> >> Rather than make yet another copy of channel(), let's move it into nir. >> >> Signed-off-by: Rob Clark >> --- >> src/glsl/nir/nir_builder.h | 6

Re: [Mesa-dev] [PATCH] nir: add nir_swizzle

2015-09-10 Thread Erik Faye-Lund
On Thu, Sep 10, 2015 at 10:08 PM, Rob Clark wrote: > From: Rob Clark > > Rather than make yet another copy of channel(), let's move it into nir. > > Signed-off-by: Rob Clark > --- > src/glsl/nir/nir_builder.h | 6 ++ > src/glsl/nir/nir_lower_tex_projector.c | 24 +

Re: [Mesa-dev] [PATCH] nir: add nir_swizzle

2015-09-10 Thread Jason Ekstrand
On Thu, Sep 10, 2015 at 1:08 PM, Rob Clark wrote: > From: Rob Clark > > Rather than make yet another copy of channel(), let's move it into nir. > > Signed-off-by: Rob Clark Reviewed-by: Jason Ekstrand > --- > src/glsl/nir/nir_builder.h | 6 ++ > src/glsl/nir/nir_lower_t

[Mesa-dev] [PATCH] nir: add nir_swizzle

2015-09-10 Thread Rob Clark
From: Rob Clark Rather than make yet another copy of channel(), let's move it into nir. Signed-off-by: Rob Clark --- src/glsl/nir/nir_builder.h | 6 ++ src/glsl/nir/nir_lower_tex_projector.c | 24 +--- src/glsl/nir/nir_normalize_cubemap_coords.c |