Re: [Mesa-dev] [PATCH] nir: Remove the const_offset from nir_tex_instr

2016-02-09 Thread Jason Ekstrand
On Feb 9, 2016 7:06 PM, "Connor Abbott" wrote: > > Did you make sure the other drivers and ttn don't use this? Assming that, Well, I deleted it from the header and the other drivers built so... > Reviewed-by: Connor Abbott > > I really should get to your other series, but I've been busy with >

Re: [Mesa-dev] [PATCH] nir: Remove the const_offset from nir_tex_instr

2016-02-09 Thread Rob Clark
On Tue, Feb 9, 2016 at 10:06 PM, Connor Abbott wrote: > Did you make sure the other drivers and ttn don't use this? Assming that, ttn doesn't use it.. freedreno does but only since I already started pushing some of my backend fixes resulting from the gallium ttn stuff that I'd been working on.

Re: [Mesa-dev] [PATCH] nir: Remove the const_offset from nir_tex_instr

2016-02-09 Thread Connor Abbott
Did you make sure the other drivers and ttn don't use this? Assming that, Reviewed-by: Connor Abbott I really should get to your other series, but I've been busy with school stuff and whatnot and I've been too lazy -- sorry! On Tue, Feb 9, 2016 at 8:08 PM, Jason Ekstrand wrote: > When NIR was

[Mesa-dev] [PATCH] nir: Remove the const_offset from nir_tex_instr

2016-02-09 Thread Jason Ekstrand
When NIR was originally drafted, there was no easy way to determine if something was constant or not. The result was that we had lots of special-casing for constant values such as this. Now that load_const instructions are SSA-only, it's really easy to find constants and this isn't really needed