Re: [Mesa-dev] [PATCH] nir: Get rid of nir_constant_data

2016-12-01 Thread Jason Ekstrand
On Thu, Dec 1, 2016 at 12:46 AM, Iago Toral wrote: > On Tue, 2016-11-29 at 22:51 -0800, Jason Ekstrand wrote: > > This has bothered me for about as long as NIR has been around. Why > > do we > > have two different unions for constants? No good reason other than > > one of > > them is a direct p

Re: [Mesa-dev] [PATCH] nir: Get rid of nir_constant_data

2016-12-01 Thread Iago Toral
On Tue, 2016-11-29 at 22:51 -0800, Jason Ekstrand wrote: > This has bothered me for about as long as NIR has been around.  Why > do we > have two different unions for constants?  No good reason other than > one of > them is a direct port from GLSL IR. > --- >  src/compiler/glsl/glsl_to_nir.cpp  | 3

[Mesa-dev] [PATCH] nir: Get rid of nir_constant_data

2016-11-29 Thread Jason Ekstrand
This has bothered me for about as long as NIR has been around. Why do we have two different unions for constants? No good reason other than one of them is a direct port from GLSL IR. --- src/compiler/glsl/glsl_to_nir.cpp | 35 src/compiler/nir/nir.c | 36 +++