Re: [Mesa-dev] [PATCH] nir: Add an ALU op builder kind of like ir_builder.h

2015-02-06 Thread Connor Abbott
Hi Eric, Sorry for not responding to this in a while. I'm replying to this comment instead of the new version because it has the relevant discussion. On Mon, Feb 2, 2015 at 7:30 PM, Eric Anholt wrote: > Connor Abbott writes: > >> I mentioned this on IRC, but it would be good to add the ability

Re: [Mesa-dev] [PATCH] nir: Add an ALU op builder kind of like ir_builder.h

2015-02-02 Thread Eric Anholt
Connor Abbott writes: > I mentioned this on IRC, but it would be good to add the ability to > append the sequence of instructions before/after an instruction as > well as at the beginning or end of a basic block. We would need to > store the current basic block, the current instruction, and an en

Re: [Mesa-dev] [PATCH] nir: Add an ALU op builder kind of like ir_builder.h

2015-01-31 Thread Kenneth Graunke
On Friday, January 30, 2015 07:27:50 PM Connor Abbott wrote: > I mentioned this on IRC, but it would be good to add the ability to > append the sequence of instructions before/after an instruction as > well as at the beginning or end of a basic block. We would need to > store the current basic bloc

Re: [Mesa-dev] [PATCH] nir: Add an ALU op builder kind of like ir_builder.h

2015-01-30 Thread Connor Abbott
I mentioned this on IRC, but it would be good to add the ability to append the sequence of instructions before/after an instruction as well as at the beginning or end of a basic block. We would need to store the current basic block, the current instruction, and an enum consisting of "insert before

[Mesa-dev] [PATCH] nir: Add an ALU op builder kind of like ir_builder.h

2015-01-30 Thread Eric Anholt
v2: Rebase on the nir_opcodes.h python code generation support. v3: Use SSA values, and set an appropriate writemask on dot products. v4: Make the arguments be SSA references as well. This lets you stack up expressions in the arguments of other expressions, at the cost of having to insert