Re: [Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name

2015-09-14 Thread Jason Ekstrand
On Sep 14, 2015 01:22, "Eduardo Lima Mitev" wrote: > > On 09/11/2015 05:58 PM, Jason Ekstrand wrote: > > On Fri, Sep 11, 2015 at 5:45 AM, Eduardo Lima Mitev wrote: > >> Reviewed-by: Eduardo Lima Mitev > > > > One side-note: Could you please reply-all when reviewing patches. > > That way you keep

Re: [Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name

2015-09-14 Thread Eduardo Lima Mitev
On 09/11/2015 05:58 PM, Jason Ekstrand wrote: > On Fri, Sep 11, 2015 at 5:45 AM, Eduardo Lima Mitev wrote: >> Reviewed-by: Eduardo Lima Mitev > > One side-note: Could you please reply-all when reviewing patches. > That way you keep the Cc list alive. While I still get it, my e-mail > client fla

Re: [Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name

2015-09-11 Thread Jason Ekstrand
On Fri, Sep 11, 2015 at 5:45 AM, Eduardo Lima Mitev wrote: > Reviewed-by: Eduardo Lima Mitev One side-note: Could you please reply-all when reviewing patches. That way you keep the Cc list alive. While I still get it, my e-mail client flags things that are specifically Cc'd to me so I notice th

Re: [Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name

2015-09-11 Thread Eduardo Lima Mitev
Reviewed-by: Eduardo Lima Mitev On 09/10/2015 10:58 PM, Jason Ekstrand wrote: > We copy the output, make the old output the temporary, and give the > temporary a new name. The copy keeps the pointer to the old name. This > works just fine up until the point where we lower things to SSA and dele

[Mesa-dev] [PATCH] nir/lower_outputs_to_temporaries: Reparent the output name

2015-09-10 Thread Jason Ekstrand
We copy the output, make the old output the temporary, and give the temporary a new name. The copy keeps the pointer to the old name. This works just fine up until the point where we lower things to SSA and delete the old variable and, with it, the name. Instead, we should re-parent to the copy.