Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-30 Thread Timothy Arceri
On 30/04/18 21:27, Alejandro Piñeiro wrote: On 30/04/18 13:02, Timothy Arceri wrote: On 30/04/18 16:59, Alejandro Piñeiro wrote: On 29/04/18 12:09, Timothy Arceri wrote: On 29/04/18 19:05, Alejandro Piñeiro wrote: On 29/04/18 10:13, Timothy Arceri wrote: On 29/04/18 16:48, Alejandro Piñeiro

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-30 Thread Alejandro Piñeiro
On 30/04/18 13:02, Timothy Arceri wrote: > On 30/04/18 16:59, Alejandro Piñeiro wrote: >> On 29/04/18 12:09, Timothy Arceri wrote: >>> On 29/04/18 19:05, Alejandro Piñeiro wrote: On 29/04/18 10:13, Timothy Arceri wrote: > On 29/04/18 16:48, Alejandro Piñeiro wrote: >> From: Eduardo Lim

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-30 Thread Timothy Arceri
On 30/04/18 16:59, Alejandro Piñeiro wrote: On 29/04/18 12:09, Timothy Arceri wrote: On 29/04/18 19:05, Alejandro Piñeiro wrote: On 29/04/18 10:13, Timothy Arceri wrote: On 29/04/18 16:48, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function will be the entry point for linking th

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-30 Thread Timothy Arceri
On 30/04/18 20:03, Alejandro Piñeiro wrote: On 30/04/18 11:53, Timothy Arceri wrote: I'll reply to the above snipped section in a separate email. Ignoring the above issue I'm fairly certain adding a dependency on core mesa GL to NIR is a no no so either way these files don't belong in src/

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-30 Thread Alejandro Piñeiro
On 30/04/18 11:53, Timothy Arceri wrote: > > I'll reply to the above snipped section in a separate email. > >>> >>> Ignoring the above issue I'm fairly certain adding a dependency on >>> core mesa GL to NIR is a no no so either way these files don't >>> belong in src/compiler/nir >> >> But we alre

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-30 Thread Timothy Arceri
I'll reply to the above snipped section in a separate email. Ignoring the above issue I'm fairly certain adding a dependency on core mesa GL to NIR is a no no so either way these files don't belong in src/compiler/nir But we already have that dependency, right? I mean gl_program have a re

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Alejandro Piñeiro
On 29/04/18 12:09, Timothy Arceri wrote: > On 29/04/18 19:05, Alejandro Piñeiro wrote: >> On 29/04/18 10:13, Timothy Arceri wrote: >>> On 29/04/18 16:48, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the ni

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Timothy Arceri
On 29/04/18 19:05, Alejandro Piñeiro wrote: On 29/04/18 10:13, Timothy Arceri wrote: On 29/04/18 16:48, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the nir_shader objects associated with the gl_linked_shaders of a progr

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Alejandro Piñeiro
On 29/04/18 10:13, Timothy Arceri wrote: > > > On 29/04/18 16:48, Alejandro Piñeiro wrote: >> From: Eduardo Lima Mitev >> >> This function will be the entry point for linking the uniforms from >> the nir_shader objects associated with the gl_linked_shaders of a >> program. >> >> This patch include

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Timothy Arceri
On 29/04/18 16:48, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the nir_shader objects associated with the gl_linked_shaders of a program. This patch includes initial support for linking uniforms from NIR shaders. It is

[Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-28 Thread Alejandro Piñeiro
From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the nir_shader objects associated with the gl_linked_shaders of a program. This patch includes initial support for linking uniforms from NIR shaders. It is tailored for the ARB_gl_spirv needs, and it is