Re: [Mesa-dev] [PATCH] nir/algebraic: Only replace an instruction once

2015-01-14 Thread Jason Ekstrand
On Wed, Jan 14, 2015 at 7:27 PM, Connor Abbott wrote: > Reviewed-by: Connor Abbott > > Just curious, how did this come about? > I was running shader-db and it was segfaulting. I'm not sure why I didn't notice it before. Perhaps it's because of the new optimizations you asked me to add? In an

Re: [Mesa-dev] [PATCH] nir/algebraic: Only replace an instruction once

2015-01-14 Thread Connor Abbott
Reviewed-by: Connor Abbott Just curious, how did this come about? On Wed, Jan 14, 2015 at 10:15 PM, Jason Ekstrand wrote: > Without the break, it was possible that an instruction would match multiple > expressions. If this happened, you could end up trying to replace it > multiple times and ge

[Mesa-dev] [PATCH] nir/algebraic: Only replace an instruction once

2015-01-14 Thread Jason Ekstrand
Without the break, it was possible that an instruction would match multiple expressions. If this happened, you could end up trying to replace it multiple times and get a segfault. This makes it so that, after a successful replacement, it moves on to the next instruction. --- src/glsl/nir/nir_alg