[Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-29 Thread Anuj Phogat
This reduces the overhead of using the fixed function internally in the driver. V2: Use setup_glsl_generate_mipmap() and setup_ff_generate_mipmap() functions to avoid code duplication. Use glsl version when ARB_{vertex, fragmet}_shader are present. Remove redundant code. V3: Remove re

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-29 Thread Ian Romanick
On 08/29/2012 08:21 AM, Brian Paul wrote: On 08/28/2012 11:28 PM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. V2: Use setup_glsl_generate_mipmap() and setup_ff_generate_mipmap() functions to avoid code duplication. Use glsl versio

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-29 Thread Ian Romanick
On 08/28/2012 10:28 PM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. V2: Use setup_glsl_generate_mipmap() and setup_ff_generate_mipmap() functions to avoid code duplication. Use glsl version when ARB_{vertex, fragmet}_shader are pre

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-29 Thread Brian Paul
On 08/28/2012 11:28 PM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. V2: Use setup_glsl_generate_mipmap() and setup_ff_generate_mipmap() functions to avoid code duplication. Use glsl version when ARB_{vertex, fragmet}_shader are pre

[Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-28 Thread Anuj Phogat
This reduces the overhead of using the fixed function internally in the driver. V2: Use setup_glsl_generate_mipmap() and setup_ff_generate_mipmap() functions to avoid code duplication. Use glsl version when ARB_{vertex, fragmet}_shader are present. Remove redundant code. Signed-off-by

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-28 Thread Anuj Phogat
On Wed, Aug 29, 2012 at 6:33 PM, Ian Romanick wrote: > On 08/27/2012 11:14 PM, Anuj Phogat wrote: >> >> This reduces the overhead of using the fixed function internally >> in the driver. >> >> Note: ARB_fragment_shader is not present in intel->gen < 4. I'll send >> out a separate patch to avoid en

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-28 Thread Ian Romanick
On 08/27/2012 11:14 PM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. Note: ARB_fragment_shader is not present in intel->gen < 4. I'll send out a separate patch to avoid enabling _mesa_meta_GenerateMipmap() in those chips. No regressions obser

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-28 Thread Brian Paul
On 08/28/2012 07:04 PM, Ian Romanick wrote: On 08/28/2012 08:58 AM, Brian Paul wrote: On 08/28/2012 12:14 AM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. Note: ARB_fragment_shader is not present in intel->gen< 4. I'll send out a separate p

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-28 Thread Ian Romanick
On 08/28/2012 08:58 AM, Brian Paul wrote: On 08/28/2012 12:14 AM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. Note: ARB_fragment_shader is not present in intel->gen< 4. I'll send out a separate patch to avoid enabling _mesa_meta_GenerateMi

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-28 Thread Brian Paul
On 08/28/2012 12:14 AM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. Note: ARB_fragment_shader is not present in intel->gen< 4. I'll send out a separate patch to avoid enabling _mesa_meta_GenerateMipmap() in those chips. No regressions obser

Re: [Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-28 Thread Brian Paul
On 08/28/2012 12:14 AM, Anuj Phogat wrote: This reduces the overhead of using the fixed function internally in the driver. Note: ARB_fragment_shader is not present in intel->gen< 4. I'll send out a separate patch to avoid enabling _mesa_meta_GenerateMipmap() in those chips. No regressions obser

[Mesa-dev] [PATCH] meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

2012-08-27 Thread Anuj Phogat
This reduces the overhead of using the fixed function internally in the driver. Note: ARB_fragment_shader is not present in intel->gen < 4. I'll send out a separate patch to avoid enabling _mesa_meta_GenerateMipmap() in those chips. No regressions observed in all.tests with this patch. Need more t