Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-06-04 Thread Martin Peres
On 04/06/15 14:02, Jose Fonseca wrote: On 04/06/15 11:53, Jose Fonseca wrote: On 04/06/15 11:23, Martin Peres wrote: On 04/06/15 13:07, Jose Fonseca wrote: On 04/06/15 10:56, Martin Peres wrote: On 04/06/15 12:53, Jose Fonseca wrote: On 31/05/15 08:10, Tapani wrote: I've read this a couple

Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-06-04 Thread Jose Fonseca
On 04/06/15 11:53, Jose Fonseca wrote: On 04/06/15 11:23, Martin Peres wrote: On 04/06/15 13:07, Jose Fonseca wrote: On 04/06/15 10:56, Martin Peres wrote: On 04/06/15 12:53, Jose Fonseca wrote: On 31/05/15 08:10, Tapani wrote: I've read this a couple of times now and cannot spot any users

Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-06-04 Thread Jose Fonseca
On 04/06/15 11:23, Martin Peres wrote: On 04/06/15 13:07, Jose Fonseca wrote: On 04/06/15 10:56, Martin Peres wrote: On 04/06/15 12:53, Jose Fonseca wrote: On 31/05/15 08:10, Tapani wrote: I've read this a couple of times now and cannot spot any users of storage that would be making a wrong

Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-06-04 Thread Martin Peres
On 04/06/15 13:07, Jose Fonseca wrote: On 04/06/15 10:56, Martin Peres wrote: On 04/06/15 12:53, Jose Fonseca wrote: On 31/05/15 08:10, Tapani wrote: I've read this a couple of times now and cannot spot any users of storage that would be making a wrong assumption, you've fixed these and I t

Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-06-04 Thread Jose Fonseca
On 04/06/15 10:56, Martin Peres wrote: On 04/06/15 12:53, Jose Fonseca wrote: On 31/05/15 08:10, Tapani wrote: I've read this a couple of times now and cannot spot any users of storage that would be making a wrong assumption, you've fixed these and I trust Jenkins was OK for i915? Everything

Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-06-04 Thread Martin Peres
On 04/06/15 12:53, Jose Fonseca wrote: On 31/05/15 08:10, Tapani wrote: I've read this a couple of times now and cannot spot any users of storage that would be making a wrong assumption, you've fixed these and I trust Jenkins was OK for i915? Everything is ok if you remove 'I think' and 'Hopef

Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-06-04 Thread Jose Fonseca
On 31/05/15 08:10, Tapani wrote: I've read this a couple of times now and cannot spot any users of storage that would be making a wrong assumption, you've fixed these and I trust Jenkins was OK for i915? Everything is ok if you remove 'I think' and 'Hopefully' from commit message :) Martin's

Re: [Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-05-31 Thread Tapani
I've read this a couple of times now and cannot spot any users of storage that would be making a wrong assumption, you've fixed these and I trust Jenkins was OK for i915? Everything is ok if you remove 'I think' and 'Hopefully' from commit message :) Reviewed-by: Tapani Pälli On 05/26/20

[Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-05-26 Thread Martin Peres
This change introduces a new field in gl_uniform_storage to explicitely say that a uniform is built-in. In the case where it is, no storage is defined to make it clear that it is read-only from the mesa side. I think I fixed all the places in the code that made use of the structure that I changed.