Re: [Mesa-dev] [PATCH] mesa: move some helper functions from fboobject.c to glformats.c

2012-11-30 Thread Ian Romanick
On 11/28/2012 04:32 PM, Marek Olšák wrote: On Thu, Nov 29, 2012 at 1:23 AM, Ian Romanick wrote: On 11/28/2012 10:07 AM, Marek Olšák wrote: It looks reasonable enough, but... why? Is there a follow-up patch that uses it them in some other file? Brian suggested it just in case somebody else n

Re: [Mesa-dev] [PATCH] mesa: move some helper functions from fboobject.c to glformats.c

2012-11-29 Thread Brian Paul
On 11/28/2012 11:07 AM, Marek Olšák wrote: --- src/mesa/main/fbobject.c | 127 +++-- src/mesa/main/glformats.c | 113 src/mesa/main/glformats.h |6 +++ 3 files changed, 127 insertions(+), 119 deletions(-)

Re: [Mesa-dev] [PATCH] mesa: move some helper functions from fboobject.c to glformats.c

2012-11-28 Thread Brian Paul
On 11/28/2012 05:23 PM, Ian Romanick wrote: On 11/28/2012 10:07 AM, Marek Olšák wrote: It looks reasonable enough, but... why? Is there a follow-up patch that uses it them in some other file? I suggested this to Marek in case we need to use these elsewhere someday and since that's where we al

Re: [Mesa-dev] [PATCH] mesa: move some helper functions from fboobject.c to glformats.c

2012-11-28 Thread Marek Olšák
On Thu, Nov 29, 2012 at 1:23 AM, Ian Romanick wrote: > On 11/28/2012 10:07 AM, Marek Olšák wrote: > > It looks reasonable enough, but... why? Is there a follow-up patch that > uses it them in some other file? Brian suggested it just in case somebody else needs to use the functions. Marek __

Re: [Mesa-dev] [PATCH] mesa: move some helper functions from fboobject.c to glformats.c

2012-11-28 Thread Ian Romanick
On 11/28/2012 10:07 AM, Marek Olšák wrote: It looks reasonable enough, but... why? Is there a follow-up patch that uses it them in some other file? --- src/mesa/main/fbobject.c | 127 +++-- src/mesa/main/glformats.c | 113

[Mesa-dev] [PATCH] mesa: move some helper functions from fboobject.c to glformats.c

2012-11-28 Thread Marek Olšák
--- src/mesa/main/fbobject.c | 127 +++-- src/mesa/main/glformats.c | 113 src/mesa/main/glformats.h |6 +++ 3 files changed, 127 insertions(+), 119 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mes