Re: [Mesa-dev] [PATCH] mesa: memset get_unpack_rgba_function's format table to 0.

2013-04-23 Thread Ian Romanick
On 04/23/2013 09:20 AM, Kenneth Graunke wrote: On 04/22/2013 09:17 PM, Ian Romanick wrote: On 04/23/2013 02:39 AM, Kenneth Graunke wrote: Otherwise, the table could be full of uninitialized garbage. That means the NULL check at the bottom might not happen, so we wouldn't get the _mesa_problem,

Re: [Mesa-dev] [PATCH] mesa: memset get_unpack_rgba_function's format table to 0.

2013-04-23 Thread Kenneth Graunke
On 04/22/2013 09:17 PM, Ian Romanick wrote: On 04/23/2013 02:39 AM, Kenneth Graunke wrote: Otherwise, the table could be full of uninitialized garbage. That means the NULL check at the bottom might not happen, so we wouldn't get the _mesa_problem, and we'd then return garbage. format_pack.c al

Re: [Mesa-dev] [PATCH] mesa: memset get_unpack_rgba_function's format table to 0.

2013-04-22 Thread Ian Romanick
On 04/23/2013 02:39 AM, Kenneth Graunke wrote: Otherwise, the table could be full of uninitialized garbage. That means the NULL check at the bottom might not happen, so we wouldn't get the _mesa_problem, and we'd then return garbage. format_pack.c also has tables like this and memsets them. T

Re: [Mesa-dev] [PATCH] mesa: memset get_unpack_rgba_function's format table to 0.

2013-04-22 Thread Matt Turner
On Mon, Apr 22, 2013 at 5:39 PM, Kenneth Graunke wrote: > Otherwise, the table could be full of uninitialized garbage. That means > the NULL check at the bottom might not happen, so we wouldn't get the > _mesa_problem, and we'd then return garbage. > > format_pack.c also has tables like this and

[Mesa-dev] [PATCH] mesa: memset get_unpack_rgba_function's format table to 0.

2013-04-22 Thread Kenneth Graunke
Otherwise, the table could be full of uninitialized garbage. That means the NULL check at the bottom might not happen, so we wouldn't get the _mesa_problem, and we'd then return garbage. format_pack.c also has tables like this and memsets them. Signed-off-by: Kenneth Graunke --- src/mesa/main/