Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-10-17 Thread Timothy Arceri
On 18/10/17 09:37, Miklós Máté wrote: On 16/10/17 01:59, Timothy Arceri wrote: On 16/10/17 04:10, Miklós Máté wrote: Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-10-17 Thread Miklós Máté
On 16/10/17 01:59, Timothy Arceri wrote: On 16/10/17 04:10, Miklós Máté wrote: Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowing the text

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-10-16 Thread Marek Olšák
On Sun, Oct 15, 2017 at 7:10 PM, Miklós Máté wrote: > Hi, > > I'd like to ask you to revert this change. > > As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however > there is a major difference between the two: with ATI_fs there is no way of > knowing the texture targets until t

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-10-15 Thread Timothy Arceri
On 16/10/17 04:10, Miklós Máté wrote: Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowing the texture targets until the draw call. When an

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-10-15 Thread Miklós Máté
Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowing the texture targets until the draw call. When an ATI_fs is created, st_init_atifs_prog()

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-09-27 Thread Kenneth Graunke
On Wednesday, September 27, 2017 8:39:27 AM PDT Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/texstate.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c > index 269e291..edd2253 100644 > --- a/

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-09-27 Thread Ian Romanick
On 09/27/2017 05:06 PM, Marek Olšák wrote: > It fixes a crash with an apitrace that I have. Other than that, no > tests. Yes, it should be tagged for stable. Ok. Adding a test would be cool, but I won't bust your chops. :) Reviewed-by: Ian Romanick > Marek > > On Thu, Sep 28, 2017 at 1:34 AM,

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-09-27 Thread Marek Olšák
It fixes a crash with an apitrace that I have. Other than that, no tests. Yes, it should be tagged for stable. Marek On Thu, Sep 28, 2017 at 1:34 AM, Ian Romanick wrote: > This looks right... at least it makes ATI_fragment_shader behave like > ARB_fragment_program. I don't suppose there are any

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-09-27 Thread Ian Romanick
This looks right... at least it makes ATI_fragment_shader behave like ARB_fragment_program. I don't suppose there are any tests that exercise this problem? Should this be tagged for stable? On 09/27/2017 08:39 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/texstate.c | 8 +

[Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-09-27 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/texstate.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 269e291..edd2253 100644 --- a/src/mesa/main/texstate.c +++ b/src/mesa/main/texstate.c @@ -833,23 +833,25 @@ update_