Re: [Mesa-dev] [PATCH] mesa: fix rgtc snorm decoding

2013-07-23 Thread Zack Rusin
Reviewed-by: Zack Rusin - Original Message - > From: Roland Scheidegger > > The codeword must be unsigned (otherwise will shift in 1's from above when > merging low/high parts so some texels decode wrong). > This also affects gallium's util/u_format_rgtc. > --- > src/mesa/main/texcompr

Re: [Mesa-dev] [PATCH] mesa: fix rgtc snorm decoding

2013-07-23 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > The codeword must be unsigned (otherwise will shift in 1's from above when > merging low/high parts so some texels decode wrong). > This also affects gallium's util/u_format_rgtc. > --- >  src/mesa/main/texcompress_rgtc_tmp.h |    6 ++

Re: [Mesa-dev] [PATCH] mesa: fix rgtc snorm decoding

2013-07-22 Thread Roland Scheidegger
Am 22.07.2013 22:52, schrieb Matt Turner: > On Mon, Jul 22, 2013 at 12:22 PM, wrote: >> From: Roland Scheidegger >> >> The codeword must be unsigned (otherwise will shift in 1's from above when >> merging low/high parts so some texels decode wrong). >> This also affects gallium's util/u_format_r

Re: [Mesa-dev] [PATCH] mesa: fix rgtc snorm decoding

2013-07-22 Thread Matt Turner
On Mon, Jul 22, 2013 at 12:22 PM, wrote: > From: Roland Scheidegger > > The codeword must be unsigned (otherwise will shift in 1's from above when > merging low/high parts so some texels decode wrong). > This also affects gallium's util/u_format_rgtc. > --- Write a piglit test for this too? ___

[Mesa-dev] [PATCH] mesa: fix rgtc snorm decoding

2013-07-22 Thread sroland
From: Roland Scheidegger The codeword must be unsigned (otherwise will shift in 1's from above when merging low/high parts so some texels decode wrong). This also affects gallium's util/u_format_rgtc. --- src/mesa/main/texcompress_rgtc_tmp.h |6 +++--- 1 file changed, 3 insertions(+), 3 dele