Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-08 Thread Bartosz Tomczyk
I confirm that the series fix all memory leaks I was observing. Tested-by: Bartosz Tomczyk On 08.04.2017 05:23, Timothy Arceri wrote: On 08/04/17 12:25, Timothy Arceri wrote: Actually please ignore that series for now. There are some issue with it I need to fix up. Sorry for the noise. V3

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Timothy Arceri
On 08/04/17 12:25, Timothy Arceri wrote: Actually please ignore that series for now. There are some issue with it I need to fix up. Sorry for the noise. V3 of the first patch should fix things up. On 08/04/17 11:13, Timothy Arceri wrote: On 08/04/17 02:25, Bartosz Tomczyk wrote: Patch di

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Timothy Arceri
Actually please ignore that series for now. There are some issue with it I need to fix up. On 08/04/17 11:13, Timothy Arceri wrote: On 08/04/17 02:25, Bartosz Tomczyk wrote: Patch didn't fix all leaks. There's one more still reported by ASAN: Direct leak of 2112 byte(s) in 12 object(s) allo

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Timothy Arceri
On 08/04/17 02:25, Bartosz Tomczyk wrote: Patch didn't fix all leaks. There's one more still reported by ASAN: Direct leak of 2112 byte(s) in 12 object(s) allocated from: #0 0x7fe18d168800 in calloc (/usr/lib/clang/3.9.1/lib/linux/libclang_rt.asan-x86_64.so

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Timothy Arceri
On 08/04/17 02:03, Brian Paul wrote: On 04/06/2017 03:55 PM, Timothy Arceri wrote: We don't need to call _mesa_reference_renderbuffer() for the first assignment as refCount starts at 1. For swrast we work around the fact we will indirectly call _mesa_reference_renderbuffer() by resetting refCo

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Bartosz Tomczyk
Patch didn't fix all leaks. There's one more still reported by ASAN: Direct leak of 2112 byte(s) in 12 object(s) allocated from: #0 0x7fe18d168800 in calloc (/usr/lib/clang/3.9.1/lib/linux/ libclang_rt.asan-x86_64.so+0xf6800) #1 0x7fe181c141f6 in st_new_renderbuffer_fb /home/bartek/Devel/m

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-07 Thread Brian Paul
On 04/06/2017 03:55 PM, Timothy Arceri wrote: We don't need to call _mesa_reference_renderbuffer() for the first assignment as refCount starts at 1. For swrast we work around the fact we will indirectly call _mesa_reference_renderbuffer() by resetting refCount to 0. Fixes: 32141e53d1520 (mesa: t

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-06 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Fri, 2017-04-07 at 07:55 +1000, Timothy Arceri wrote: > We don't need to call _mesa_reference_renderbuffer() for the first > assignment as refCount starts at 1. For swrast we work around the > fact we will indirectly call _mesa_reference_renderbuffer() by

[Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-06 Thread Timothy Arceri
We don't need to call _mesa_reference_renderbuffer() for the first assignment as refCount starts at 1. For swrast we work around the fact we will indirectly call _mesa_reference_renderbuffer() by resetting refCount to 0. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) ---