Re: [Mesa-dev] [PATCH] mesa: fix error handling for glMaterial*

2011-09-20 Thread Brian Paul
On 09/19/2011 11:32 PM, Yuanhan Liu wrote: Trigger GL_INVALID_ENUM error if the face paramter is not a valid value. Trigger GL_INVALID_VALUE error if the GL_SHININESS value is out side [0, ctx->Constant.MaxShiniess]. v2: fix the max shininess value. v3: suggested by Brian, move the face check

Re: [Mesa-dev] [PATCH] mesa: fix error handling for glMaterial*

2011-09-19 Thread Yuanhan Liu
On Mon, Sep 19, 2011 at 09:25:54PM -0600, Brian Paul wrote: > On Mon, Sep 19, 2011 at 9:16 PM, Yuanhan Liu > wrote: > > Trigger GL_INVALID_ENUM error if the face paramter is not a valid value. > > > > Trigger GL_INVALID_VALUE error if the GL_SHININESS value is out side > > [0, ctx->Constant.MaxShi

[Mesa-dev] [PATCH] mesa: fix error handling for glMaterial*

2011-09-19 Thread Yuanhan Liu
Trigger GL_INVALID_ENUM error if the face paramter is not a valid value. Trigger GL_INVALID_VALUE error if the GL_SHININESS value is out side [0, ctx->Constant.MaxShiniess]. v2: fix the max shininess value. v3: suggested by Brian, move the face check into glMaterialfv function to reduce code

Re: [Mesa-dev] [PATCH] mesa: fix error handling for glMaterial*

2011-09-19 Thread Brian Paul
On Mon, Sep 19, 2011 at 9:16 PM, Yuanhan Liu wrote: > Trigger GL_INVALID_ENUM error if the face paramter is not a valid value. > > Trigger GL_INVALID_VALUE error if the GL_SHININESS value is out side > [0, ctx->Constant.MaxShiniess]. > > v2: fix the max shininess value. > > Signed-off-by: Yuanhan

[Mesa-dev] [PATCH] mesa: fix error handling for glMaterial*

2011-09-19 Thread Yuanhan Liu
Trigger GL_INVALID_ENUM error if the face paramter is not a valid value. Trigger GL_INVALID_VALUE error if the GL_SHININESS value is out side [0, ctx->Constant.MaxShiniess]. v2: fix the max shininess value. Signed-off-by: Yuanhan Liu --- src/mesa/vbo/vbo_attrib_tmp.h | 11 ++- 1 file