Re: [Mesa-dev] [PATCH] mesa: clamp MaxLevel for immutable textures at initialization

2015-10-22 Thread Ilia Mirkin
On Thu, Oct 22, 2015 at 12:03 PM, Nicolai Hähnle wrote: > On 22.10.2015 15:57, Fredrik Höglund wrote: >> >> On Thursday 22 October 2015, Nicolai Hähnle wrote: >>> >>> The same clamping already happens for glTexParameteri. This change >>> also fixes a bug in mipmap generation, see >>> https://bugs.

Re: [Mesa-dev] [PATCH] mesa: clamp MaxLevel for immutable textures at initialization

2015-10-22 Thread Nicolai Hähnle
On 22.10.2015 15:57, Fredrik Höglund wrote: On Thursday 22 October 2015, Nicolai Hähnle wrote: The same clamping already happens for glTexParameteri. This change also fixes a bug in mipmap generation, see https://bugs.freedesktop.org/show_bug.cgi?id=91993 I don't think this patch is correct.

Re: [Mesa-dev] [PATCH] mesa: clamp MaxLevel for immutable textures at initialization

2015-10-22 Thread Fredrik Höglund
On Thursday 22 October 2015, Nicolai Hähnle wrote: > The same clamping already happens for glTexParameteri. This change > also fixes a bug in mipmap generation, see > https://bugs.freedesktop.org/show_bug.cgi?id=91993 I don't think this patch is correct. The ARB_texture_view specification doesn't

[Mesa-dev] [PATCH] mesa: clamp MaxLevel for immutable textures at initialization

2015-10-22 Thread Nicolai Hähnle
The same clamping already happens for glTexParameteri. This change also fixes a bug in mipmap generation, see https://bugs.freedesktop.org/show_bug.cgi?id=91993 piglit test cases have been submitted for review (as additions to arb_texture_storage-texture-storage and arb_texture_view-max-level). --