On Sat, Dec 15, 2012 at 7:02 AM, Stéphane Marchesin
wrote:
> On Fri, Dec 14, 2012 at 12:52 PM, Frank Henigman
> wrote:
>> No piglet regressions and now passes glsl-uniform-out-of-bounds-2.
>>
>>
Should this have gone into the stable 9.0 branch?
Dave.
___
On Fri, Dec 14, 2012 at 12:52 PM, Frank Henigman wrote:
> No piglet regressions and now passes glsl-uniform-out-of-bounds-2.
>
>
> validate_uniform_parameters now checks that the array index is
> valid. This means if an index is out of bounds, glGetUniform* now
> fails with GL_INVALID_OPERATION,
No piglet regressions and now passes glsl-uniform-out-of-bounds-2.
validate_uniform_parameters now checks that the array index is
valid. This means if an index is out of bounds, glGetUniform* now
fails with GL_INVALID_OPERATION, as it should.
_mesa_uniform and _mesa_uniform_matrix also call
vali
New piglit test:
http://lists.freedesktop.org/archives/piglit/2012-November/003690.html
On Mon, Nov 5, 2012 at 12:04 PM, Frank Henigman wrote:
> Should have mentioned it does pass piglit, but now that I look I don't see
> any tests generating an out-of-bounds array index. I also made my own test
Should have mentioned it does pass piglit, but now that I look I don't see
any tests generating an out-of-bounds array index. I also made my own test
program which does go out of bounds, and I'll submit that for inclusion in
piglit.
On Fri, Nov 2, 2012 at 4:51 PM, Ian Romanick wrote:
> On 11/02
On 11/02/2012 01:12 PM, Frank Henigman wrote:
validate_uniform_parameters now checks that the array index is
valid. This means if an index is out of bounds, glGetUniform* now
fails with GL_INVALID_OPERATION, as it should.
_mesa_uniform and _mesa_uniform_matrix also call
validate_uniform_paramete
validate_uniform_parameters now checks that the array index is
valid. This means if an index is out of bounds, glGetUniform* now
fails with GL_INVALID_OPERATION, as it should.
_mesa_uniform and _mesa_uniform_matrix also call
validate_uniform_parameters so the bounds checks there became
redundant a
