Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-20 Thread Brian Paul
On 10/20/2011 01:23 PM, Ian Romanick wrote: On 10/17/2011 01:59 PM, Brian Paul wrote: On 10/17/2011 02:45 PM, Eric Anholt wrote: The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). Bugzilla: https:

Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-20 Thread Ian Romanick
On 10/17/2011 01:59 PM, Brian Paul wrote: On 10/17/2011 02:45 PM, Eric Anholt wrote: The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40308

Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-20 Thread Eric Anholt
On Tue, 18 Oct 2011 16:56:48 -0600, Brian Paul wrote: > On 10/18/2011 04:09 PM, Eric Anholt wrote: > > The spec doesn't explicitly mandate this behavior, but it seems like > > the only sensible thing to do (as opposed to assertion failing or > > segfaulting). > > > > v2: Do the early return before

Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-18 Thread Brian Paul
On 10/18/2011 04:09 PM, Eric Anholt wrote: The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). v2: Do the early return before calling into the driver function. Bugzilla: https://bugs.freedesktop.org

[Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-18 Thread Eric Anholt
The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). v2: Do the early return before calling into the driver function. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40308 --- src/mesa/main/fbo

Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-17 Thread Brian Paul
On 10/17/2011 02:45 PM, Eric Anholt wrote: The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40308 --- Oops, looks like I never sent this one

[Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-17 Thread Eric Anholt
The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40308 --- Oops, looks like I never sent this one out for review. src/mesa/main/mipmap.c |