Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-21 Thread Eric Anholt
Chad Versace writes: > On 08/20/2012 02:17 PM, Matt Turner wrote: >> On Mon, Aug 20, 2012 at 1:52 PM, Chad Versace >> wrote: >>> Add -Wno-narrowing to CXXFLAGS if gcc supports it. >>> >>> This removes warnings of the form >>> warning: narrowing conversion of X from 'int' to 'float' inside {

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-20 Thread Chad Versace
On 08/20/2012 02:17 PM, Matt Turner wrote: > On Mon, Aug 20, 2012 at 1:52 PM, Chad Versace > wrote: >> Add -Wno-narrowing to CXXFLAGS if gcc supports it. >> >> This removes warnings of the form >> warning: narrowing conversion of X from 'int' to 'float' inside { } is >> ill-formed in C++11

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-20 Thread Matt Turner
On Mon, Aug 20, 2012 at 1:52 PM, Chad Versace wrote: > Add -Wno-narrowing to CXXFLAGS if gcc supports it. > > This removes warnings of the form > warning: narrowing conversion of X from 'int' to 'float' inside { } is > ill-formed in C++11 [-Wnarrowing] > in ff_fragment_shader.cpp and gen6_

[Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-20 Thread Chad Versace
Add -Wno-narrowing to CXXFLAGS if gcc supports it. This removes warnings of the form warning: narrowing conversion of X from 'int' to 'float' inside { } is ill-formed in C++11 [-Wnarrowing] in ff_fragment_shader.cpp and gen6_blorp.cpp. When building i965, I observed no other difference in

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-14 Thread Chad Versace
On 08/10/2012 03:40 PM, Chí-Thanh Christopher Nguyễn wrote: > Chad Versace schrieb: > >> This opens a larger question. gcc 4.2 was released in May 2007, over 5 years >> ago, and received its last update in May 2008. How old of a gcc should new >> Mesa >> releases support? >> >> Before 2007 I had

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chí-Thanh Christopher Nguyễn
Chad Versace schrieb: > This opens a larger question. gcc 4.2 was released in May 2007, over 5 years > ago, and received its last update in May 2008. How old of a gcc should new > Mesa > releases support? > > Before 2007 I had not even been introduced to Linux, so I'm not in a position > to > a

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Chad Versace wrote: This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? That's a fair point - that was on an old LFS AGP box I don't really use apart from booting now and a

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Andy Furniss wrote: Chad Versace wrote: Andy, I just reverted the patch. Ok, thanks This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? That's a fair point - that wa

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
>> This opens a larger question. gcc 4.2 was released in May 2007, over 5 years >> ago, and received its last update in May 2008. How old of a gcc should new >> Mesa >> releases support? > > That's a fair point - that was on an old LFS AGP box I don't really use apart > from booting now and again

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Chad Versace wrote: Andy, I just reverted the patch. Ok, thanks This opens a larger question. gcc 4.2 was released in May 2007, over 5 years ago, and received its last update in May 2008. How old of a gcc should new Mesa releases support? That's a fair point - that was on an old LFS AGP b

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
On 08/10/2012 11:40 AM, Andy Furniss wrote: > Kenneth Graunke wrote: >> On 08/10/2012 07:51 AM, Chad Versace wrote: >>> On 08/09/2012 01:22 PM, Kenneth Graunke wrote: On 08/09/2012 01:10 PM, Chad Versace wrote: > Add -Wno-narrowing to CXXFLAGS for gcc. > > This removes warnings of

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Andy Furniss
Kenneth Graunke wrote: On 08/10/2012 07:51 AM, Chad Versace wrote: On 08/09/2012 01:22 PM, Kenneth Graunke wrote: On 08/09/2012 01:10 PM, Chad Versace wrote: Add -Wno-narrowing to CXXFLAGS for gcc. This removes warnings of the form warning: narrowing conversion of X from 'int' to 'float'

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
> Oh cool! :D > > I had no idea it did that. > > Reviewed-by: Kenneth Graunke Thanks. It's now pushed, and our builds less complainy :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Kenneth Graunke
On 08/10/2012 07:51 AM, Chad Versace wrote: > On 08/09/2012 01:22 PM, Kenneth Graunke wrote: >> On 08/09/2012 01:10 PM, Chad Versace wrote: >>> Add -Wno-narrowing to CXXFLAGS for gcc. >>> >>> This removes warnings of the form >>> warning: narrowing conversion of X from 'int' to 'float' inside {

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-10 Thread Chad Versace
On 08/09/2012 01:22 PM, Kenneth Graunke wrote: > On 08/09/2012 01:10 PM, Chad Versace wrote: >> Add -Wno-narrowing to CXXFLAGS for gcc. >> >> This removes warnings of the form >> warning: narrowing conversion of X from 'int' to 'float' inside { } is >> ill-formed in C++11 [-Wnarrowing] >> i

Re: [Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-09 Thread Kenneth Graunke
On 08/09/2012 01:10 PM, Chad Versace wrote: > Add -Wno-narrowing to CXXFLAGS for gcc. > > This removes warnings of the form > warning: narrowing conversion of X from 'int' to 'float' inside { } is > ill-formed in C++11 [-Wnarrowing] > in ff_fragment_shader.cpp and gen6_blorp.cpp of the for

[Mesa-dev] [PATCH] mesa: Remove C++11 narrowing warnings

2012-08-09 Thread Chad Versace
Add -Wno-narrowing to CXXFLAGS for gcc. This removes warnings of the form warning: narrowing conversion of X from 'int' to 'float' inside { } is ill-formed in C++11 [-Wnarrowing] in ff_fragment_shader.cpp and gen6_blorp.cpp of the form. When building i965, I observed no other difference i