Re: [Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

2014-02-18 Thread Ian Romanick
On 02/17/2014 04:21 PM, Courtney Goeltzenleuchter wrote: > I've updated the patch to set the flipped flag as well. > > I verified that all the flags were being set. As for the data in the > rest of the structure that is filled in from the compressed data using > whatever technique was coded in the

Re: [Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

2014-02-17 Thread Courtney Goeltzenleuchter
I've updated the patch to set the flipped flag as well. I verified that all the flags were being set. As for the data in the rest of the structure that is filled in from the compressed data using whatever technique was coded in the compressed data. I don't think it's necessary to zero out the full

Re: [Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

2014-02-14 Thread Ian Romanick
On 02/14/2014 08:05 AM, Courtney Goeltzenleuchter wrote: > Initialize field to eliminate valgrind warning. There are a couple other fields that aren't set it all paths (e.g., flipped). I want to suggest just memseting the whole structure, but it's not obvious to me how it's used throughout the co

[Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

2014-02-14 Thread Courtney Goeltzenleuchter
Initialize field to eliminate valgrind warning. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/texcompress_etc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/texcompress_etc.c b/src/mesa/main/texcompress_etc.c index f9234b0..97adc86 100644 --- a/src/mesa/main/texc

[Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

2014-02-14 Thread Courtney Goeltzenleuchter
Initialize field to eliminate valgrind warning. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/texcompress_etc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/texcompress_etc.c b/src/mesa/main/texcompress_etc.c index f9234b0..97adc86 100644 --- a/src/mesa/main/texc