Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

2015-09-10 Thread Ian Romanick
On 07/01/2015 11:00 PM, Jose Fonseca wrote: > On 02/07/15 06:55, Matt Turner wrote: >> On Wed, Jul 1, 2015 at 3:22 PM, Ilia Mirkin wrote: >>> The optimization logic relies on being able to read out constbuf values >>> from program parameters. However that only works if there's no relative >>> addr

Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

2015-07-01 Thread Jose Fonseca
On 02/07/15 06:55, Matt Turner wrote: On Wed, Jul 1, 2015 at 3:22 PM, Ilia Mirkin wrote: The optimization logic relies on being able to read out constbuf values from program parameters. However that only works if there's no relative addressing involved. Bugzilla: https://bugs.freedesktop.org/s

Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

2015-07-01 Thread Matt Turner
On Wed, Jul 1, 2015 at 3:22 PM, Ilia Mirkin wrote: > The optimization logic relies on being able to read out constbuf values > from program parameters. However that only works if there's no relative > addressing involved. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91173 > Signed-of

Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

2015-07-01 Thread Chris Forbes
Seems fair. Reviewed-by: Chris Forbes On Thu, Jul 2, 2015 at 10:22 AM, Ilia Mirkin wrote: > The optimization logic relies on being able to read out constbuf values > from program parameters. However that only works if there's no relative > addressing involved. > > Bugzilla: https://bugs.freedes

Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

2015-07-01 Thread Ilia Mirkin
Ian, looks like you added this code back in antiquity... commit 54c48a95e6e0573886433f94ac83293876ffe03d Author: Ian Romanick Date: Thu Feb 10 15:48:27 2011 -0800 mesa: Add partial constant propagation pass for Mesa IR On Wed, Jul 1, 2015 at 6:22 PM, Ilia Mirkin wrote: > The optimization

[Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

2015-07-01 Thread Ilia Mirkin
The optimization logic relies on being able to read out constbuf values from program parameters. However that only works if there's no relative addressing involved. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91173 Signed-off-by: Ilia Mirkin --- src/mesa/program/prog_opt_constant_fold