Re: [Mesa-dev] [PATCH] mesa/main: fix error checking logic on CopyImageSubData

Reviewed-by: Jason Ekstrand On Jul 2, 2016 2:48 AM, "Nicolai Hähnle" wrote: > Reviewed-by: Nicolai Hähnle > > On 01.07.2016 19:03, Alejandro Piñeiro wrote: > >> For the case (both src or dst) where we had a texobject, but the >> texobject target was not the same that the method target, this spe

Re: [Mesa-dev] [PATCH] mesa/main: fix error checking logic on CopyImageSubData

Thanks for the review. And probably asking too much, would you mind to take a look to the piglit patch that adapts the related piglit test to the new behaviour?: https://lists.freedesktop.org/archives/piglit/2016-July/020153.html On 02/07/16 11:48, Nicolai Hähnle wrote: > Reviewed-by: Nicolai Häh

Re: [Mesa-dev] [PATCH] mesa/main: fix error checking logic on CopyImageSubData

Reviewed-by: Nicolai Hähnle On 01.07.2016 19:03, Alejandro Piñeiro wrote: For the case (both src or dst) where we had a texobject, but the texobject target was not the same that the method target, this spec paragraph was appplied: /* Section 18.3.2 (Copying Between Images) of the OpenGL 4.5

[Mesa-dev] [PATCH] mesa/main: fix error checking logic on CopyImageSubData

For the case (both src or dst) where we had a texobject, but the texobject target was not the same that the method target, this spec paragraph was appplied: /* Section 18.3.2 (Copying Between Images) of the OpenGL 4.5 Core * Profile spec says: * * "An INVALID_VALUE error is generated if