Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

On 04/04/17 13:54, Bartosz Tomczyk wrote: Thank you Timothy. Sorry about that, I'm still quite to new git/Mesa workflow. I will do better in future. Not a problem :) Thanks for the patches. On Apr 4, 2017 01:54, "Timothy Arceri" mailto:tarc...@itsqueeze.com>> wrote: I've pushed this.

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

Thank you Timothy. Sorry about that, I'm still quite to new git/Mesa workflow. I will do better in future. On Apr 4, 2017 01:54, "Timothy Arceri" wrote: I've pushed this. Thanks! In future please add the version to the subject when sending new revisions. You can do this with the -v option whe

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

I've pushed this. Thanks! In future please add the version to the subject when sending new revisions. You can do this with the -v option when using git send-email e.g -v2 will result in [PATCH v2] Also please add changes to the patch since v1 in the commit message. e.g. V2: set batch->used =

[Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

--- src/mesa/main/glthread.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/glthread.c b/src/mesa/main/glthread.c index 3f07c420d4..c4d3f4a434 100644 --- a/src/mesa/main/glthread.c +++ b/src/mesa/main/glthread.c @@ -53,7 +53,8 @@ glthread_allocate

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

On 03.04.2017 20:53, Bartosz Tomczyk wrote: Actually, I can just set only batch->used to 0, but it seems to error prone. When someone adds some fields to batch struct, it will be easy to miss that it should be initialized in glthread_unmarshal_batch. Better to have it fail early and loudly with

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

Actually, I can just set only batch->used to 0, but it seems to error prone. When someone adds some fields to batch struct, it will be easy to miss that it should be initialized in glthread_unmarshal_batch. Anyway I can change it if you want to. On Mon, Apr 3, 2017 at 8:42 PM, Nicolai Hähnle wro

Re: [Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

On 03.04.2017 20:38, Bartosz Tomczyk wrote: --- src/mesa/main/glthread.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/glthread.c b/src/mesa/main/glthread.c index 3f07c420d4..aa14292e59 100644 --- a/src/mesa/main/glthread.c +++ b/src/mesa/main/

[Mesa-dev] [PATCH] mesa/glthread: Avoid unnecessary batch reallocation

--- src/mesa/main/glthread.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/glthread.c b/src/mesa/main/glthread.c index 3f07c420d4..aa14292e59 100644 --- a/src/mesa/main/glthread.c +++ b/src/mesa/main/glthread.c @@ -53,7 +53,8 @@ glthread_allocate