Re: [Mesa-dev] [PATCH] mapi: automake: set VISIBILITY_CFLAGS for shared glapi

2016-10-24 Thread Emil Velikov
On 24 October 2016 at 11:28, Eric Engestrom wrote: > On Saturday, 2016-10-22 18:19:53 +1100, Jonathan Gray wrote: >> shared glapi was previously built without setting CFLAGS for >> AM_CFLAGS and VISIBILITY_CFLAGS. >> >> This resulted in symbols being exported that shouldn't be. >> >> The x86 and s

Re: [Mesa-dev] [PATCH] mapi: automake: set VISIBILITY_CFLAGS for shared glapi

2016-10-24 Thread Eric Engestrom
On Saturday, 2016-10-22 18:19:53 +1100, Jonathan Gray wrote: > shared glapi was previously built without setting CFLAGS for > AM_CFLAGS and VISIBILITY_CFLAGS. > > This resulted in symbols being exported that shouldn't be. > > The x86 and sparc assembly versions of the dispatch table partially > m

[Mesa-dev] [PATCH] mapi: automake: set VISIBILITY_CFLAGS for shared glapi

2016-10-22 Thread Jonathan Gray
shared glapi was previously built without setting CFLAGS for AM_CFLAGS and VISIBILITY_CFLAGS. This resulted in symbols being exported that shouldn't be. The x86 and sparc assembly versions of the dispatch table partially mitigated this by using .hidden. Otherwise shared_dispatch_stub_* were bein