Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

2017-08-30 Thread Roland Scheidegger
Am 30.08.2017 um 16:46 schrieb Brian Paul: > On 08/30/2017 02:43 AM, Roland Scheidegger wrote: >> Am 30.08.2017 um 04:49 schrieb Brian Paul: >>> On 08/29/2017 06:17 PM, Roland Scheidegger wrote: Looks good to me, thanks. Reviewed-by: Roland Scheidegger Albeit I'm not quite

Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

2017-08-30 Thread Brian Paul
On 08/30/2017 02:43 AM, Roland Scheidegger wrote: Am 30.08.2017 um 04:49 schrieb Brian Paul: On 08/29/2017 06:17 PM, Roland Scheidegger wrote: Looks good to me, thanks. Reviewed-by: Roland Scheidegger Albeit I'm not quite sure why it is never set here? This particular test sets a 0 x 0 sci

Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

2017-08-30 Thread Roland Scheidegger
Am 30.08.2017 um 04:49 schrieb Brian Paul: > On 08/29/2017 06:17 PM, Roland Scheidegger wrote: >> Looks good to me, thanks. >> >> Reviewed-by: Roland Scheidegger >> >> Albeit I'm not quite sure why it is never set here? > > This particular test sets a 0 x 0 scissor region.  All the > pipe_scissor

Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

2017-08-29 Thread Brian Paul
On 08/29/2017 06:17 PM, Roland Scheidegger wrote: Looks good to me, thanks. Reviewed-by: Roland Scheidegger Albeit I'm not quite sure why it is never set here? This particular test sets a 0 x 0 scissor region. All the pipe_scissor_state members are zero and when the state tracker does a m

Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

2017-08-29 Thread Roland Scheidegger
Looks good to me, thanks. Reviewed-by: Roland Scheidegger Albeit I'm not quite sure why it is never set here? This bug looks similar in nature to the uninitialized fb (see 8bfe451ed30918244618608871423b2a72cf9767) and I thought that was impossible to hit with gl state tracker... Roland Am 28.0

Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

2017-08-29 Thread Emil Velikov
On 28 August 2017 at 21:20, Brian Paul wrote: > If llvmpipe_set_scissor_states() is never called, we still need to be sure > that derived scissor/clip state is updated. As of commit 743ad599a97d09b1 > that function might not be called. > > Fixes regressed Piglit gl-1.0-scissor-offscreen -fbo -aut

[Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

2017-08-28 Thread Brian Paul
If llvmpipe_set_scissor_states() is never called, we still need to be sure that derived scissor/clip state is updated. As of commit 743ad599a97d09b1 that function might not be called. Fixes regressed Piglit gl-1.0-scissor-offscreen -fbo -auto test. Bugzilla: https://bugs.freedesktop.org/show_bug