Re: [Mesa-dev] [PATCH] llvmpipe: fix lp_resource_copy using more than one 3d slice

2013-02-19 Thread Roland Scheidegger
Am 19.02.2013 10:13, schrieb Jose Fonseca: > Thanks for fixing this Roland. > > This is definitely an improvement. I'd recommend a few tweaks (it could even > be as a follow on change): > > - Calling llvmpipe_flush_resource() in a loop is overkill (it will call > llvmpipe_flush() to be called m

Re: [Mesa-dev] [PATCH] llvmpipe: fix lp_resource_copy using more than one 3d slice

2013-02-19 Thread Jose Fonseca
Thanks for fixing this Roland. This is definitely an improvement. I'd recommend a few tweaks (it could even be as a follow on change): - Calling llvmpipe_flush_resource() in a loop is overkill (it will call llvmpipe_flush() to be called many times needlessly). Please refactor llvmpipe_flush_re

[Mesa-dev] [PATCH] llvmpipe: fix lp_resource_copy using more than one 3d slice

2013-02-18 Thread sroland
From: Roland Scheidegger These used to be illegal a very long time ago, then for some more time nothing really emitted these so this code path wasn't hit. Just trivially iterate over box->depth. (Might be worth refactoring at some point since nowadays all the code doesn't really do much except fo