Re: [Mesa-dev] [PATCH] llvmpipe: Check thread creation errors

2019-11-11 Thread Nathan Kidd
Thanks. I'll have to rely on someone with a commit bit to push this. On 2019-11-10 4:55 p.m., Roland Scheidegger wrote: > Looks great to me. > Reviewed-by: Roland Scheidegger > > Am 08.11.19 um 23:05 schrieb Nathan Kidd: >> In the case of glibc, pthread_t is internally a pointer. If >> lp_ras

Re: [Mesa-dev] [PATCH] llvmpipe: Check thread creation errors

2019-11-10 Thread Roland Scheidegger
Looks great to me. Reviewed-by: Roland Scheidegger Am 08.11.19 um 23:05 schrieb Nathan Kidd: > In the case of glibc, pthread_t is internally a pointer. If > lp_rast_destroy() passes a 0-value pthread_t to pthread_join(), the > latter will SEGV dereferencing it. > > pthread_create() can fail if

[Mesa-dev] [PATCH] llvmpipe: Check thread creation errors

2019-11-08 Thread Nathan Kidd
In the case of glibc, pthread_t is internally a pointer. If lp_rast_destroy() passes a 0-value pthread_t to pthread_join(), the latter will SEGV dereferencing it. pthread_create() can fail if either the user's ulimit -u or Linux kernel's /proc/sys/kernel/threads-max is reached. Choosing to conti