Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-22 Thread Yuanhan Liu
On Thu, Sep 22, 2011 at 10:26:37PM -0700, Eric Anholt wrote: > On Fri, 23 Sep 2011 11:09:14 +0800, Yuanhan Liu > wrote: > > On Thu, Sep 08, 2011 at 09:12:44PM -0700, Kenneth Graunke wrote: > > > On 09/08/2011 07:56 PM, Yuanhan Liu wrote: > > > > There is already comments show how to detect a null

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-22 Thread Eric Anholt
On Fri, 23 Sep 2011 11:09:14 +0800, Yuanhan Liu wrote: > On Thu, Sep 08, 2011 at 09:12:44PM -0700, Kenneth Graunke wrote: > > On 09/08/2011 07:56 PM, Yuanhan Liu wrote: > > > There is already comments show how to detect a null texture. Fix the > > > code to match the comments. > > > > > > This w

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-22 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 09:12:44PM -0700, Kenneth Graunke wrote: > On 09/08/2011 07:56 PM, Yuanhan Liu wrote: > > There is already comments show how to detect a null texture. Fix the > > code to match the comments. > > > > This would fix the oglc divzero(basic.texQOrWEqualsZero) and > > divzero(ba

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 09:12:44PM -0700, Kenneth Graunke wrote: > On 09/08/2011 07:56 PM, Yuanhan Liu wrote: > > There is already comments show how to detect a null texture. Fix the > > code to match the comments. > > > > This would fix the oglc divzero(basic.texQOrWEqualsZero) and > > divzero(ba

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
On Fri, Sep 09, 2011 at 10:56:36AM +0800, Yuanhan Liu wrote: > There is already comments show how to detect a null texture. Fix the > code to match the comments. > > This would fix the oglc divzero(basic.texQOrWEqualsZero) and > divzero(basic.texTrivialPrim) test case fail. > > Signed-off-by: Yua

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Kenneth Graunke
On 09/08/2011 07:56 PM, Yuanhan Liu wrote: > There is already comments show how to detect a null texture. Fix the > code to match the comments. > > This would fix the oglc divzero(basic.texQOrWEqualsZero) and > divzero(basic.texTrivialPrim) test case fail. > > Signed-off-by: Yuanhan Liu > --- >

[Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
There is already comments show how to detect a null texture. Fix the code to match the comments. This would fix the oglc divzero(basic.texQOrWEqualsZero) and divzero(basic.texTrivialPrim) test case fail. Signed-off-by: Yuanhan Liu --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c |2 +- 1