Re: [Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 01:16:23PM -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/08/2011 03:16 AM, Yuanhan Liu wrote: > > If user call glTexImage1D with width = 0 and height = 0(the last > > level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart,

Re: [Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2011 03:16 AM, Yuanhan Liu wrote: > If user call glTexImage1D with width = 0 and height = 0(the last > level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart, > 0, 0, format, type, pixel) > > It would generate a SIGSEGV fault. As i9

[Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Yuanhan Liu
If user call glTexImage1D with width = 0 and height = 0(the last level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart, 0, 0, format, type, pixel) It would generate a SIGSEGV fault. As i945_miptree_layout_2d didn't handle this special case. More info are commented in line in this patch.