Re: [Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width >= 32kbytes

2013-01-28 Thread Paul Berry
On 24 January 2013 13:59, Eric Anholt wrote: > Paul Berry writes: > > > Yeah, you're right. I was being lazy. How's this: > > > * Furthermore, intelEmitCopyBlit (which is called by > > * intel_miptree_map_blit) uses a signed 16-bit integer to represent > > buffer > > * pitch, so it

Re: [Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width >= 32kbytes

2013-01-24 Thread Eric Anholt
Paul Berry writes: > Yeah, you're right. I was being lazy. How's this: > * Furthermore, intelEmitCopyBlit (which is called by > * intel_miptree_map_blit) uses a signed 16-bit integer to represent > buffer > * pitch, so it can only handle buffer pitches < 32k. > * > * As a r

Re: [Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width >= 32kbytes

2013-01-24 Thread Ian Romanick
On 01/24/2013 02:10 PM, Paul Berry wrote: When possible, glReadPixels calls are performed using the hardware blitter. However, according to the Ivy Bridge PRM, Vol1 Part4, section 1.2.1.2 (Graphics Data Size Limitations): The BLT engine is capable of transferring very large quantities of

Re: [Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width >= 32kbytes

2013-01-24 Thread Eric Anholt
Paul Berry writes: > When possible, glReadPixels calls are performed using the hardware > blitter. However, according to the Ivy Bridge PRM, Vol1 Part4, > section 1.2.1.2 (Graphics Data Size Limitations): > > The BLT engine is capable of transferring very large quantities of > graphics d

Re: [Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width >= 32kbytes

2013-01-24 Thread Paul Berry
Yeah, you're right. I was being lazy. How's this: /* According to the Ivy Bridge PRM, Vol1 Part4, section 1.2.1.2 (Graphics * Data Size Limitations): * *The BLT engine is capable of transferring very large quantities of *graphics data. Any graphics data read from and w

Re: [Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width >= 32kbytes

2013-01-24 Thread Alex Deucher
On Thu, Jan 24, 2013 at 2:10 PM, Paul Berry wrote: > When possible, glReadPixels calls are performed using the hardware > blitter. However, according to the Ivy Bridge PRM, Vol1 Part4, > section 1.2.1.2 (Graphics Data Size Limitations): > > The BLT engine is capable of transferring very large

[Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width >= 32kbytes

2013-01-24 Thread Paul Berry
When possible, glReadPixels calls are performed using the hardware blitter. However, according to the Ivy Bridge PRM, Vol1 Part4, section 1.2.1.2 (Graphics Data Size Limitations): The BLT engine is capable of transferring very large quantities of graphics data. Any graphics data read from