Re: [Mesa-dev] [PATCH] intel/blorp: Set needs_(dst|src)_offset for Gen4 cubemaps

2017-06-06 Thread Jason Ekstrand
On Tue, Jun 6, 2017 at 9:10 AM, Ian Romanick wrote: > On 06/05/2017 06:03 PM, Jason Ekstrand wrote: > > On Mon, Jun 5, 2017 at 5:22 PM, Ian Romanick > > wrote: > > > > From: Jason Ekstrand > > > > > > We call convert_to_s

Re: [Mesa-dev] [PATCH] intel/blorp: Set needs_(dst|src)_offset for Gen4 cubemaps

2017-06-06 Thread Ian Romanick
On 06/05/2017 06:03 PM, Jason Ekstrand wrote: > On Mon, Jun 5, 2017 at 5:22 PM, Ian Romanick > wrote: > > From: Jason Ekstrand > > > We call convert_to_single_slice so they may end up with a non-trivial > offset that

Re: [Mesa-dev] [PATCH] intel/blorp: Set needs_(dst|src)_offset for Gen4 cubemaps

2017-06-05 Thread Jason Ekstrand
On Mon, Jun 5, 2017 at 5:22 PM, Ian Romanick wrote: > From: Jason Ekstrand > > We call convert_to_single_slice so they may end up with a non-trivial > offset that needs to be taken into account. > > v2 (idr): Also set needs_src_offset. Suggested by Jason. > > Fixes ES2-CTS.functional.texture.sp

[Mesa-dev] [PATCH] intel/blorp: Set needs_(dst|src)_offset for Gen4 cubemaps

2017-06-05 Thread Ian Romanick
From: Jason Ekstrand We call convert_to_single_slice so they may end up with a non-trivial offset that needs to be taken into account. v2 (idr): Also set needs_src_offset. Suggested by Jason. Fixes ES2-CTS.functional.texture.specification.basic_copyteximage2d.cube_rgba and ES2-CTS.functional.t