Re: [Mesa-dev] [PATCH] indices: fix provoking vertex for quads/quadstrips

2015-04-07 Thread Ilia Mirkin
Mystery semi-solved? Previously u_primconvert would always select *FIRST* provoking order when flatshading wasn't enabled, but the quads would still follow the "last" logic. No big deal. I added support for quads to be able to follow the provoking vertex convention, but now the way that the quad is

Re: [Mesa-dev] [PATCH] indices: fix provoking vertex for quads/quadstrips

2015-04-07 Thread Roland Scheidegger
It will look different with llvmpipe if you use the right debug variables (GALLIVM_DEBUG=no_brilinear,no_quad_lod,no_rho_approx), though still fail. I think the test may not be really valid. This is because if you use texgrad, the driver/hw probably will (or should) use per-pixel lod. But if you do

Re: [Mesa-dev] [PATCH] indices: fix provoking vertex for quads/quadstrips

2015-04-07 Thread Ilia Mirkin
Oh fun, those tests also fail with nvc0 and llvmpipe. But pass on softpipe. (The llvmpipe fail is visually different from the nvc0 and freedreno/a3xx one though.) On Tue, Apr 7, 2015 at 10:25 AM, Ilia Mirkin wrote: > Weird, this seems to regress > > bin/arb_shader_texture_lod-texgrad > bin/arb_sh

Re: [Mesa-dev] [PATCH] indices: fix provoking vertex for quads/quadstrips

2015-04-07 Thread Ilia Mirkin
Weird, this seems to regress bin/arb_shader_texture_lod-texgrad bin/arb_shader_texture_lod-texgradcube Visually they look the same, but piglit finds small differences. On Tue, Apr 7, 2015 at 2:20 AM, Ilia Mirkin wrote: > On Tue, Apr 7, 2015 at 1:44 AM, Ilia Mirkin wrote: >> Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH] indices: fix provoking vertex for quads/quadstrips

2015-04-06 Thread Ilia Mirkin
On Tue, Apr 7, 2015 at 1:44 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > Pushing this through a complete piglit run, but it seems to fix > > bin/arb-provoking-vertex-render > > on a3xx. Please take special care to double-check that I didn't mess > up cw/ccw order or something.

[Mesa-dev] [PATCH] indices: fix provoking vertex for quads/quadstrips

2015-04-06 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Pushing this through a complete piglit run, but it seems to fix bin/arb-provoking-vertex-render on a3xx. Please take special care to double-check that I didn't mess up cw/ccw order or something. I'm especially weak on the quadstrip case. src/gallium/auxiliary/