Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

2018-01-22 Thread Emil Velikov
On 21 January 2018 at 16:15, Jason Ekstrand wrote: > Fair enough. I wasn't sure what you meant. > > Reviewed-by: Jason Ekstrand > Thanks, tweaked a bit and pushed to master. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.

Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

2018-01-21 Thread Jason Ekstrand
Fair enough. I wasn't sure what you meant. Reviewed-by: Jason Ekstrand On January 21, 2018 08:02:44 Emil Velikov wrote: On 19 January 2018 at 16:17, Jason Ekstrand wrote: Why? I think it's probably fine but changing signedness of a variable is always a bit tricky. As said in the commi

Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

2018-01-21 Thread Emil Velikov
On 19 January 2018 at 16:17, Jason Ekstrand wrote: > Why? I think it's probably fine but changing signedness of a variable is > always a bit tricky. > As said in the commit message - all the call sites already consider it as unsigned. Quick grep shows: brw_state_upload.c: const unsigned fb_sa

Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

2018-01-19 Thread Jason Ekstrand
Why? I think it's probably fine but changing signedness of a variable is always a bit tricky. On January 19, 2018 08:04:24 Emil Velikov wrote: From: Emil Velikov Already used as such through the codebase. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1

[Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

2018-01-19 Thread Emil Velikov
From: Emil Velikov Already used as such through the codebase. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index 79e