Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-06 Thread Kenneth Graunke
On 09/05/2011 06:34 PM, Yuanhan Liu wrote: > Fix the constant interpolation enable bit mask for flat light mode. > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > shift one more bit right. > > This would fix the oglc specularColor test fail on both Sandybridge and > Ivybridge. >

Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-06 Thread Eric Anholt
On Tue, 6 Sep 2011 09:34:00 +0800, Yuanhan Liu wrote: > Fix the constant interpolation enable bit mask for flat light mode. > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > shift one more bit right. > > This would fix the oglc specularColor test fail on both Sandybridge and

[Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
Fix the constant interpolation enable bit mask for flat light mode. FRAG_BIT_COL0 attribute bit might be 0, in which case we need to shift one more bit right. This would fix the oglc specularColor test fail on both Sandybridge and Ivybridge. Signed-off-by: Yuanhan Liu Signed-off-by: Xiang, Haiha

Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
On Mon, Sep 05, 2011 at 10:41:03AM -0700, Eric Anholt wrote: > On Mon, 5 Sep 2011 15:59:32 +0800, Yuanhan Liu > wrote: > > Fix the constant interpolation enable bit mask for flat light mode. > > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > > shift one more bit right. > > >

[Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
Fix the constant interpolation enable bit mask for flat light mode. FRAG_BIT_COL0 attribute bit might be 0, in which case we need to shift one more bit right. This would fix the oglc specularColor test fail on both Sandybridge and Ivybridge. v2: move the constant interp bitmask setup code into fo

Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Eric Anholt
On Mon, 5 Sep 2011 15:59:32 +0800, Yuanhan Liu wrote: > Fix the constant interpolation enable bit mask for flat light mode. > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > shift one more bit right. > > This would fix the oglc specularColor test fail on both Sandybridge and

[Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
Fix the constant interpolation enable bit mask for flat light mode. FRAG_BIT_COL0 attribute bit might be 0, in which case we need to shift one more bit right. This would fix the oglc specularColor test fail on both Sandybridge and Ivybridge. Signed-off-by: Yuanhan Liu Signed-off-by: Xiang, Haiha