Re: [Mesa-dev] [PATCH] i965: clearify map_gtt cases

2018-09-04 Thread Chris Wilson
Quoting Kenneth Graunke (2018-09-04 16:13:59) > On Tuesday, September 4, 2018 2:57:29 AM PDT Lionel Landwerlin wrote: > > Both brw_bo_map_cpu() & brw_bo_map_wc() assert if mapping the > > underlying BO fails. Failing back to brw_bo_map_gtt() doesn't seem to > > make any sense for that reason. > >

Re: [Mesa-dev] [PATCH] i965: clearify map_gtt cases

2018-09-04 Thread Kenneth Graunke
On Tuesday, September 4, 2018 2:57:29 AM PDT Lionel Landwerlin wrote: > Both brw_bo_map_cpu() & brw_bo_map_wc() assert if mapping the > underlying BO fails. Failing back to brw_bo_map_gtt() doesn't seem to > make any sense for that reason. > > We also only call brw_bo_map_gtt() for tiled buffers w

Re: [Mesa-dev] [PATCH] i965: clearify map_gtt cases

2018-09-04 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-09-04 10:57:29) > Both brw_bo_map_cpu() & brw_bo_map_wc() assert if mapping the > underlying BO fails. Failing back to brw_bo_map_gtt() doesn't seem to > make any sense for that reason. > > We also only call brw_bo_map_gtt() for tiled buffers which as far as > we kn

[Mesa-dev] [PATCH] i965: clearify map_gtt cases

2018-09-04 Thread Lionel Landwerlin
Both brw_bo_map_cpu() & brw_bo_map_wc() assert if mapping the underlying BO fails. Failing back to brw_bo_map_gtt() doesn't seem to make any sense for that reason. We also only call brw_bo_map_gtt() for tiled buffers which as far as we know are never mapped coherent (coherent is a parameter reserv