Re: [Mesa-dev] [PATCH] i965: Set dirty bit for NOS fragment shader change

2014-12-23 Thread Mike Stroyan
Ah, I see. I was assuming that a necessary dirty bit had not been set. But the right dirty bit had been set and was being ignored. Watching the right dirty bit is going to look a bit different in 10.3 or 10.4. It will need to use ".cache = CACHE_NEW_WM_PROG" in brw_texture_surfaces instead of addi

Re: [Mesa-dev] [PATCH] i965: Set dirty bit for NOS fragment shader change

2014-12-22 Thread Kenneth Graunke
On Monday, December 22, 2014 05:22:06 PM Mike Stroyan wrote: > This patch fixes a problem I reported as > [Bug 87619] Changes to state such as render targets change fragment shader > without marking it dirty. > > I sent a test that demonstrates the problem to the piglit mailing list as > fbo: Cha

Re: [Mesa-dev] [PATCH] i965: Set dirty bit for NOS fragment shader change

2014-12-22 Thread Ian Romanick
On 12/22/2014 04:22 PM, Mike Stroyan wrote: > A fragment program can change because of Non-Orthogonal-State changes. > brw_update_texture_surfaces needs to run because of changed surface offsets. > Set BRW_NEW_FRAGMENT_PROGRAM dirty bit in brw_upload_wm_prog to signal that. Please add Bugzilla: h

[Mesa-dev] [PATCH] i965: Set dirty bit for NOS fragment shader change

2014-12-22 Thread Mike Stroyan
A fragment program can change because of Non-Orthogonal-State changes. brw_update_texture_surfaces needs to run because of changed surface offsets. Set BRW_NEW_FRAGMENT_PROGRAM dirty bit in brw_upload_wm_prog to signal that. --- src/mesa/drivers/dri/i965/brw_wm.c | 9 - 1 file changed, 8 i

[Mesa-dev] [PATCH] i965: Set dirty bit for NOS fragment shader change

2014-12-22 Thread Mike Stroyan
This patch fixes a problem I reported as [Bug 87619] Changes to state such as render targets change fragment shader without marking it dirty. I sent a test that demonstrates the problem to the piglit mailing list as fbo: Changing mrt binding with same shader source The root cause of problem is r