Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

2013-08-18 Thread Kenneth Graunke
On Sunday, August 18, 2013 09:34:37 AM Paul Berry wrote: > We are getting close to the maximum number of BRW_NEW_* bits that can > be stored in brw->state.dirty.brw without overflowing 32 bits, and > geometry shaders are going to add more. Add a STATIC_ASSERT so that > we will be alerted when we n

Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

2013-08-18 Thread Paul Berry
On 18 August 2013 10:30, Mark Mueller wrote: > When the time comes, are there any concerns with using a 64 bit type, like > portability? 64 bits for flags would be useful for something that I'm > looking into and I'm curious how much pain that could cause. > We already use 64-bit bitfields in se

Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

2013-08-18 Thread Mark Mueller
When the time comes, are there any concerns with using a 64 bit type, like portability? 64 bits for flags would be useful for something that I'm looking into and I'm curious how much pain that could cause. On Sun, Aug 18, 2013 at 10:58 AM, Ian Romanick wrote: > On 08/18/2013 09:34 AM, Paul Berr

Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

2013-08-18 Thread Ian Romanick
On 08/18/2013 09:34 AM, Paul Berry wrote: We are getting close to the maximum number of BRW_NEW_* bits that can be stored in brw->state.dirty.brw without overflowing 32 bits, and geometry shaders are going to add more. Add a STATIC_ASSERT so that we will be alerted when we need to switch to 64 b

[Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

2013-08-18 Thread Paul Berry
We are getting close to the maximum number of BRW_NEW_* bits that can be stored in brw->state.dirty.brw without overflowing 32 bits, and geometry shaders are going to add more. Add a STATIC_ASSERT so that we will be alerted when we need to switch to 64 bits. --- src/mesa/drivers/dri/i965/brw_cont